Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758412AbcC2XJj (ORCPT ); Tue, 29 Mar 2016 19:09:39 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:53558 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758315AbcC2XJh (ORCPT ); Tue, 29 Mar 2016 19:09:37 -0400 Date: Tue, 29 Mar 2016 16:09:31 -0700 From: Mark Brown To: Stephen Boyd Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Georgi Djakov , David Collins Message-ID: <20160329230931.GT2350@sirena.org.uk> References: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Zltv+KEU+AMUCOPj" Content-Disposition: inline In-Reply-To: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org> X-Cookie: If anything can go wrong, it will. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 64.55.107.4 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 33 --Zltv+KEU+AMUCOPj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 29, 2016 at 03:58:40PM -0700, Stephen Boyd wrote: > - if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS) { > - ret = spmi_regulator_ftsmps_init_slew_rate(vreg); > + if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS || > + vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_LO_SMPS || > + vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_HO_SMPS || > + vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_SMPS) { > + ret = spmi_regulator_init_slew_rate(vreg); This should be a switch statement. Otherwise this looks fine. --Zltv+KEU+AMUCOPj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW+wsaAAoJECTWi3JdVIfQyQgH/1Wr5il8KKRX7kQhlb5YqnPp Dn0NXXbn02wCcbVjqyF2pfS//n647HJv/yATy5qtJd8XTL8jM5slUhMh2efy/iML Ubewg3nGACE2a6vLiw/CWZ6u8OWg1/JtQeLH6FyFqKU733LJwi7ZQTD63OmhY4kO Qwf2qeK6dXVK96ZFAzcSadduc0NcmfIxIb5YqafC2VdpILUD1SL6l74NGq3dyENV V2zQ6NUtQexms9HElsqr12kgGH/wvUND51dbDX8nq8xx0W0V7m6bEKl7hkorVs0U vFwVjS5AvH0y/XR9Grnw5gLUk26lJYgPqsmzpTJMpqGM+47b3ZoOdZ3StUSNILs= =Hvjp -----END PGP SIGNATURE----- --Zltv+KEU+AMUCOPj--