Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756836AbcC3AY4 (ORCPT ); Tue, 29 Mar 2016 20:24:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:43497 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbcC3AYy (ORCPT ); Tue, 29 Mar 2016 20:24:54 -0400 From: NeilBrown To: Ilya Dryomov Date: Wed, 30 Mar 2016 11:24:44 +1100 Cc: Sage Weil , "linux-kernel\@vger.kernel.org" , Ceph Development Subject: Re: [GIT PULL] Ceph fixes for -rc7 In-Reply-To: References: <87fuvfw6g9.fsf@notabene.neil.brown.name> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-suse-linux-gnu) Message-ID: <874mbovmlv.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3276 Lines: 95 --=-=-= Content-Type: text/plain On Fri, Mar 25 2016, Ilya Dryomov wrote: > On Fri, Mar 25, 2016 at 5:02 AM, NeilBrown wrote: >> On Sun, Mar 06 2016, Sage Weil wrote: >> >>> Hi Linus, >>> >>> Please pull the following Ceph patch from >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus >>> >>> This is a final commit we missed to align the protocol compatibility with >>> the feature bits. It decodes a few extra fields in two different messages >>> and reports EIO when they are used (not yet supported). >>> >>> Thanks! >>> sage >>> >>> >>> ---------------------------------------------------------------- >>> Yan, Zheng (1): >>> ceph: initial CEPH_FEATURE_FS_FILE_LAYOUT_V2 support >> >> Just wondering, but was CEPH_FEATURE_FS_FILE_LAYOUT_V2 supposed to have >> exactly the same value as CEPH_FEATURE_NEW_OSDOPREPLY_ENCODING (and >> CEPH_FEATURE_CRUSH_TUNABLES5)?? > > Yes, that was the point of getting it merged into -rc7. I did wonder if that might be the case. > >> Because when I backported this patch (and many others) to some ancient >> enterprise kernel, it caused mounts to fail. If it really is meant to >> be the same value, then I must have some other backported issue to find >> and fix. > > It has to be backported in concert with changes that add support for > the other two bits. I have everything from fs/ceph and net/ceph as of 4.5, with adjustments for different core code. > How did mount fail? "can't read superblock". dmesg contains [ 50.822479] libceph: client144098 fsid 2b73bc29-3e78-490a-8fc6-21da1bf901ba [ 50.823746] libceph: mon0 192.168.1.122:6789 session established [ 51.635312] ceph: problem parsing mds trace -5 [ 51.635317] ceph: mds parse_reply err -5 [ 51.635318] ceph: mdsc_handle_reply got corrupt reply mds0(tid:1) then a hex dump of header:, front: footer: Maybe my MDS is causing the problem? It is based on v10.0.5 which contains #define CEPH_FEATURE_CRUSH_TUNABLES5 (1ULL<<58) /* chooseleaf stable mode */ // duplicated since it was introduced at the same time as CEPH_FEATURE_CRUSH_TUN #define CEPH_FEATURE_NEW_OSDOPREPLY_ENCODING (1ULL<<58) /* New, v7 encoding */ in ceph_features.h i.e. two features using bit 58, but not FS_FILE_LAYOUT_V2 Should I expect Linux 4.5 to work with ceph 10.0.5 ?? Thanks, NeilBrown --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW+xzNAAoJEDnsnt1WYoG5leEP/09A0T9BA0G93qnOl2ga6uX/ jJvgxHg3qKKAKNoGTRFIFHCq1t8XhUUvXpRyz3fMkLBghvr4h7UCFR8qLsrYp/Az V/hG0IY4E66zi5JC95wk3kiTjQvoZJk1Bmt7cHxXrrw4L90bd1FNCWzuLNrdHX1R VAB33u6zep4KftFHq9KIFN41bM8KJIrEmMPapjZ0L77WHFYB3XHANRF9pfnMezsv 0BKLCUDyaxXxECN9tXL2RVoqZ71Gze6On0hYeoALbezrfpJNhQHpF21RCTSjg9BM gwMsPqzCQNwRpY9woCV+9QrSfsHCyDr4sYl75mBBXlTPW9FG+EWPh1juF7oh994Q 2dMGjoW6/YmcOd4UV7Oui/9S8G/o8u3crdqQZmirzFtuISFByJl3sVpI6JENSsKR e/uzVz6R0LQ7oUtxls/lMf1MM1NxAyIBU58BhhJam8BkpmWq9SdpC6rEeQvM5ynv iKhlKFoV59nExZSQu+UNIHTIzgX9GjTC2J1fzJ0sQxCf2zWxSziOy3yAcR5KyxeT eUUEUPiCUiaoz4vLSFW3fPBqiaqYTbkmyv70B4fCHag2VV47w4CQWeSFU6n2mBkQ PoiqIJYeFAle/fOK+glYRR7eqS5NPX/YKS8A8Nf0F4zfZlKz/J4n3yrRNYyp4OBS 98tnGHUidc6XjrxCnw5J =aZx0 -----END PGP SIGNATURE----- --=-=-=--