Date: Wed, 30 Mar 2016 09:23:10 +0800
From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/vfs: improve __mnt_is_readonly
Message-ID: <20160330012310.GA3497@yaowei-K42JY>
References: <1458871286-3099-1-git-send-email-baiyaowei@cmss.chinamobile.com>
 <20160326004332.GM17997@ZenIV.linux.org.uk>
 <20160329063544.GA3588@yaowei-K42JY>
 <CAFLxGvyZ0eszz8CiTtd9U98b7Q2n_TDfV5A=jeb-jLu-Dt8Xdg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFLxGvyZ0eszz8CiTtd9U98b7Q2n_TDfV5A=jeb-jLu-Dt8Xdg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1049
Lines: 28

On Tue, Mar 29, 2016 at 11:43:21AM +0200, Richard Weinberger wrote:
> On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai
> <baiyaowei@cmss.chinamobile.com> wrote:
> > On Sat, Mar 26, 2016 at 12:43:32AM +0000, Al Viro wrote:
> >> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote:
> >> > This patch refactors __mnt_is_readonly and makes it return bool to
> >> > improve readability due to this particular function only using either
> >> > one or zero as its return value.
> >>
> >> Improve in which way, if I may ask?
> >
> > A boolean return value can be more matchable with function's name and
> > more suitable as this function only returns 0/1.
> 
> Please also think of the arguments made on linux-mtd[1].
> Hopping from one subsystem to another trying to sneak patches
> in is not the best idea... :-)

Acturally, this patch was sent before the mtd ones and all of them were sent
in one shot. You're really thinking too much.:-)

> 
> [1]: http://lists.infradead.org/pipermail/linux-mtd/2016-March/066296.html
> 
> -- 
> Thanks,
> //richard