Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758591AbcC3CyQ (ORCPT ); Tue, 29 Mar 2016 22:54:16 -0400 Received: from mail-db3on0096.outbound.protection.outlook.com ([157.55.234.96]:22816 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758495AbcC3CyL (ORCPT ); Tue, 29 Mar 2016 22:54:11 -0400 X-Greylist: delayed 64351 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Mar 2016 22:54:10 EDT From: Jun Li To: Baolin Wang CC: Peter Chen , Felipe Balbi , "Greg KH" , Sebastian Reichel , "Dmitry Eremin-Solenikov" , David Woodhouse , Peter Chen , Alan Stern , "r.baldyga@samsung.com" , Yoshihiro Shimoda , Lee Jones , Mark Brown , Charles Keepax , "patches@opensource.wolfsonmicro.com" , Linux PM list , USB , "device-mainlining@lists.linuxfoundation.org" , LKML Subject: RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Thread-Topic: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Thread-Index: AQHRhcncDPeno7bqik6en7wacMJBHJ9pvwGAgASx+gCAAa8+QIAAFJIAgAEXTJA= Date: Wed, 30 Mar 2016 02:54:05 +0000 Message-ID: References: <20160325070937.GA22398@peterchendt> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [123.151.195.51] x-ms-office365-filtering-correlation-id: d5c19625-599c-4255-b78c-08d358468f17 x-microsoft-exchange-diagnostics: 1;AM4PR04MB1665;5:OsL4iB1hne6rjZNRhfnSiMyF+LYsGpt5nmy3vR4IhsUSk5RUw6Yj19bw4i7eNp2bCMo6EzFSstdWCGCly8Ru0ZniAxeMaTCH02dsSboJTZCcadHkKGErSakr+GgGWl3ySfRhnoqQNV5IXM6WB7eyng==;24:iNHt+mgcI9/RR0lzwL5e1MrQVbrDsbzp278CHlxzCuyEPAL9UEbnzd6QUQrJ1T6BuvkbEJ8Gtu0rGkd86cieruBvV4X0JTJKmiUkR3erdcQ= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM4PR04MB1665; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:AM4PR04MB1665;BCL:0;PCL:0;RULEID:;SRVR:AM4PR04MB1665; x-forefront-prvs: 08978A8F5C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(377454003)(13464003)(106116001)(33656002)(66066001)(2950100001)(2900100001)(54356999)(76176999)(81166005)(5002640100001)(93886004)(5004730100002)(86362001)(11100500001)(102836003)(74316001)(6116002)(3846002)(15975445007)(5003600100002)(586003)(50986999)(87936001)(92566002)(76576001)(5008740100001)(4326007)(189998001)(3660700001)(3280700002)(110136002)(2906002)(1096002)(1220700001)(19580395003)(5250100002)(19580405001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR04MB1665;H:AM4PR04MB1665.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2016 02:54:05.9460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR04MB1665 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u2U2sM14019966 Content-Length: 4472 Lines: 107 > -----Original Message----- > From: Baolin Wang [mailto:baolin.wang@linaro.org] > Sent: Tuesday, March 29, 2016 5:49 PM > To: Jun Li > Cc: Peter Chen ; Felipe Balbi ; > Greg KH ; Sebastian Reichel ; > Dmitry Eremin-Solenikov ; David Woodhouse > ; Peter Chen ; Alan Stern > ; r.baldyga@samsung.com; Yoshihiro Shimoda > ; Lee Jones ; Mark > Brown ; Charles Keepax > ; patches@opensource.wolfsonmicro.com; > Linux PM list ; USB ; > device-mainlining@lists.linuxfoundation.org; LKML kernel@vger.kernel.org> > Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with > the usb gadget power negotation > > On 29 March 2016 at 16:45, Jun Li wrote: > > > > > >> -----Original Message----- > >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb- > >> owner@vger.kernel.org] On Behalf Of Baolin Wang > >> Sent: Monday, March 28, 2016 2:52 PM > >> To: Peter Chen > >> Cc: Felipe Balbi ; Greg KH > >> ; Sebastian Reichel ; > >> Dmitry Eremin-Solenikov ; David Woodhouse > >> ; Peter Chen ; Alan > >> Stern ; r.baldyga@samsung.com; Yoshihiro > >> Shimoda ; Lee Jones > >> ; Mark Brown ; Charles > >> Keepax ; > >> patches@opensource.wolfsonmicro.com; > >> Linux PM list ; USB > >> ; > >> device-mainlining@lists.linuxfoundation.org; LKML >> kernel@vger.kernel.org> > >> Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal > >> with the usb gadget power negotation > >> > >> On 25 March 2016 at 15:09, Peter Chen wrote: > >> > On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: > >> >> Currently the Linux kernel does not provide any standard > >> >> integration of this feature that integrates the USB subsystem with > >> >> the system power regulation provided by PMICs meaning that either > >> >> vendors must add this in their kernels or USB gadget devices based > >> >> on Linux (such as mobile phones) may not behave as they should. > >> >> Thus provide a > >> standard framework for doing this in kernel. > >> >> > >> >> Now introduce one user with wm831x_power to support and test the > >> >> usb charger, which is pending testing. Moreover there may be other > >> >> potential users will use it in future. > >> >> > >> > > >> > I am afraid I still not find the user (udc driver) for this > >> > framework, I would like to see how udc driver block the enumeration > >> > until the charger detection has finished, or am I missing something? > >> > >> It is not for udc driver but for power users who want to negotiate > >> with USB subsystem. > >> > > > > Seems you don't want to guarantee charger type detection is done > > before gadget connection(pullup DP), right? > > I see you call usb_charger_detect_type() in each gadget usb state > changes. > > I am not sure I get your point correctly, please correct me if I > misunderstand you. > We need to check the charger type at every event comes from the usb gadget > state changes or the extcon device state changes, which means a new > charger plugin or pullup. > According to usb charger spec, my understanding is you can't do real charger detection procedure *after* gadget _connection_(pullup DP), also I don't think it's necessary to check charger type at every event from usb gadget. Something in gadget driver you can utilize is only vbus detection, and report diff current by diff usb state if it's a SDP. > > > > Li Jun > >> > > >> > -- > >> > Best Regards, > >> > Peter Chen > >> > >> > >> > >> -- > >> Baolin.wang > >> Best Regards > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-usb" > >> in the body of a message to majordomo@vger.kernel.org More majordomo > >> info at http://vger.kernel.org/majordomo-info.html > > > > -- > Baolin.wang > Best Regards