Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbcC3GeU (ORCPT ); Wed, 30 Mar 2016 02:34:20 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:14523 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752933AbcC3GeS (ORCPT ); Wed, 30 Mar 2016 02:34:18 -0400 Date: Wed, 30 Mar 2016 14:33:53 +0800 From: Denis Ciocca To: Arnd Bergmann CC: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Giuseppe BARBA , Linus Walleij , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] iio: st_magn: always define ST_MAGN_TRIGGER_SET_STATE Message-ID: <20160330063353.GA6253@beicxl1122> References: <1459283273-1059478-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1459283273-1059478-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-30_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 41 Hi Arnd, yup, my fault. Thanks. Acked-by: Denis Ciocca On |29 Mar 16 @ 22:27|, Arnd Bergmann wrote: > When CONFIG_IIO_TRIGGER is enabled but CONFIG_IIO_BUFFER is > not, we get a build error in the st_magn driver: > > drivers/iio/magnetometer/st_magn_core.c:573:23: error: 'ST_MAGN_TRIGGER_SET_STATE' undeclared here (not in a function) > .set_trigger_state = ST_MAGN_TRIGGER_SET_STATE, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Apparently, this ST_MAGN_TRIGGER_SET_STATE macro was meant to > be set to NULL when the definition is not available because > st_magn_buffer.c is not compiled, but the alternative definition > was not included in the original patch. This adds it. > > Signed-off-by: Arnd Bergmann > Fixes: 74f5683f35fe ("iio: st_magn: Add irq trigger handling") > --- > drivers/iio/magnetometer/st_magn.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/magnetometer/st_magn.h b/drivers/iio/magnetometer/st_magn.h > index 06a4d9c35581..9daca4681922 100644 > --- a/drivers/iio/magnetometer/st_magn.h > +++ b/drivers/iio/magnetometer/st_magn.h > @@ -44,6 +44,7 @@ static inline int st_magn_allocate_ring(struct iio_dev *indio_dev) > static inline void st_magn_deallocate_ring(struct iio_dev *indio_dev) > { > } > +#define ST_MAGN_TRIGGER_SET_STATE NULL > #endif /* CONFIG_IIO_BUFFER */ > > #endif /* ST_MAGN_H */ > -- > 2.7.0 >