Date: Wed, 30 Mar 2016 08:46:12 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        linux-kernel@vger.kernel.org,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>, pi3orama@163.com,
        Zefan Li <lizefan@huawei.com>
Subject: Re: [PATCH 1/4] perf core: Introduce new ioctl options to pause and
 resume ring buffer
Message-ID: <20160330064612.GR3408@twins.programming.kicks-ass.net>
References: <1459147292-239310-1-git-send-email-wangnan0@huawei.com>
 <1459147292-239310-2-git-send-email-wangnan0@huawei.com>
 <20160329125423.GJ3408@twins.programming.kicks-ass.net>
 <56FB326E.9030909@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56FB326E.9030909@huawei.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 873
Lines: 23

On Wed, Mar 30, 2016 at 09:57:02AM +0800, Wangnan (F) wrote:
> 
> 
> On 2016/3/29 20:54, Peter Zijlstra wrote:
> >On Mon, Mar 28, 2016 at 06:41:29AM +0000, Wang Nan wrote:
> >>Add new ioctl() to pause/resume ring-buffer output.
> >>
> >>In some situations we want to read from ring buffer only when we
> >>ensure nothing can write to the ring buffer during reading. Without
> >>this patch we have to turn off all events attached to this ring buffer
> >>to achieve this.
> >>
> >>This patch is for supporting overwrite ring buffer. Following
> >>commits will introduce new methods support reading from overwrite ring
> >>buffer. Before reading, caller must ensure the ring buffer is frozen, or
> >>the reading is unreliable.
> >>
> >>Signed-off-by: Wang Nan <wangnan0@huawei.com>
> >I made the below changes.
> 
> Can I add your SOB when I resend it?

No need, I've got it.