Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754772AbcC3Gyo (ORCPT ); Wed, 30 Mar 2016 02:54:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:51786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028AbcC3Gym (ORCPT ); Wed, 30 Mar 2016 02:54:42 -0400 Message-ID: <1459320877.4102.3.camel@kernel.org> Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io From: Vishal Verma To: Christoph Hellwig , Vishal Verma Cc: Jens Axboe , Jan Kara , Andrew Morton , linux-nvdimm@ml01.01.org, Dave Chinner , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, linux-block@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Al Viro Date: Wed, 30 Mar 2016 00:54:37 -0600 In-Reply-To: <20160330063415.GA2132@infradead.org> References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-6-git-send-email-vishal.l.verma@intel.com> <20160330063415.GA2132@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.1 (3.18.5.1-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 315 Lines: 8 On Tue, 2016-03-29 at 23:34 -0700, Christoph Hellwig wrote: > Hi Vishal, > > still NAK to calling the direct I/O code directly from the dax code. Hm, I thought this was what you meant -- do the fallback/retry attempts at the callers of dax_do_io instead of the new dax wrapper function.. Did I misunderstand you?