Subject: Re: [PATCH] fs/vfs: improve __mnt_is_readonly
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
References: <1458871286-3099-1-git-send-email-baiyaowei@cmss.chinamobile.com>
 <20160326004332.GM17997@ZenIV.linux.org.uk>
 <20160329063544.GA3588@yaowei-K42JY>
 <CAFLxGvyZ0eszz8CiTtd9U98b7Q2n_TDfV5A=jeb-jLu-Dt8Xdg@mail.gmail.com>
 <20160330012310.GA3497@yaowei-K42JY>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
From: Richard Weinberger <richard@nod.at>
Message-ID: <56FB8082.6080501@nod.at>
Date: Wed, 30 Mar 2016 09:30:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <20160330012310.GA3497@yaowei-K42JY>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1059
Lines: 26

Am 30.03.2016 um 03:23 schrieb Yaowei Bai:
> On Tue, Mar 29, 2016 at 11:43:21AM +0200, Richard Weinberger wrote:
>> On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai
>> <baiyaowei@cmss.chinamobile.com> wrote:
>>> On Sat, Mar 26, 2016 at 12:43:32AM +0000, Al Viro wrote:
>>>> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote:
>>>>> This patch refactors __mnt_is_readonly and makes it return bool to
>>>>> improve readability due to this particular function only using either
>>>>> one or zero as its return value.
>>>>
>>>> Improve in which way, if I may ask?
>>>
>>> A boolean return value can be more matchable with function's name and
>>> more suitable as this function only returns 0/1.
>>
>> Please also think of the arguments made on linux-mtd[1].
>> Hopping from one subsystem to another trying to sneak patches
>> in is not the best idea... :-)
> 
> Acturally, this patch was sent before the mtd ones and all of them were sent
> in one shot. You're really thinking too much.:-)

I was referring to your answer not to your patch.

Thanks,
//richard