Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758687AbcC3HfN (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Mar 2016 03:35:13 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:52372 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758645AbcC3HfL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Mar 2016 03:35:11 -0400
Message-ID: <56FB8180.5040205@huawei.com>
Date: Wed, 30 Mar 2016 15:34:24 +0800
From: Shannon Zhao <zhaoshenglong@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Julien Grall <julien.grall@arm.com>,
        Shannon Zhao <shannon.zhao@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <stefano.stabellini@citrix.com>, <david.vrabel@citrix.com>
CC: <devicetree@vger.kernel.org>, <linux-efi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <catalin.marinas@arm.com>,
        <will.deacon@arm.com>, <peter.huangpeng@huawei.com>,
        <xen-devel@lists.xen.org>
Subject: Re: [PATCH v7 10/17] arm/xen: Get event-channel irq through HVM_PARAM
 when booting with ACPI
References: <1458830676-27075-1-git-send-email-shannon.zhao@linaro.org> <1458830676-27075-11-git-send-email-shannon.zhao@linaro.org> <56FAAEED.7060108@arm.com>
In-Reply-To: <56FAAEED.7060108@arm.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.16.142]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090202.56FB819D.0179,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 80a09979e01a377f6c388571d14942da
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2033
Lines: 65



On 2016/3/30 0:35, Julien Grall wrote:
> Hi Shannon,
> 
> On 24/03/16 14:44, Shannon Zhao wrote:
>> When booting with ACPI, it could get the event-channel irq through
> 
> The kernel will always get the event-channel IRQ through
> HVM_PARAM_CALLBACK_IRQ.
> 
> So I would say: ", the kernel will get the event-channel..."
> 
>> HVM_PARAM_CALLBACK_IRQ.
>>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>> ---
>>   arch/arm/xen/enlighten.c | 36 +++++++++++++++++++++++++++++++++++-
>>   1 file changed, 35 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
>> index d94f726..680aae0 100644
>> --- a/arch/arm/xen/enlighten.c
>> +++ b/arch/arm/xen/enlighten.c
>> @@ -30,6 +30,7 @@
>>   #include <linux/time64.h>
>>   #include <linux/timekeeping.h>
>>   #include <linux/timekeeper_internal.h>
>> +#include <linux/acpi.h>
>>
>>   #include <linux/mm.h>
>>
>> @@ -278,6 +279,35 @@ void __init xen_early_init(void)
>>           add_preferred_console("hvc", 0, NULL);
>>   }
>>
>> +static void __init xen_acpi_guest_init(void)
>> +{
>> +#ifdef CONFIG_ACPI
>> +    struct xen_hvm_param a;
>> +    int interrupt, trigger, polarity;
>> +
>> +    a.domid = DOMID_SELF;
>> +    a.index = HVM_PARAM_CALLBACK_IRQ;
>> +    xen_events_irq = 0;
>> +
>> +    if (!HYPERVISOR_hvm_op(HVMOP_get_param, &a)) {
>> +        if ((a.value >> 56) == HVM_PARAM_CALLBACK_TYPE_PPI) {
>> +            interrupt = a.value & 0xff;
>> +            trigger = ((a.value >> 8) & 0x1) ? ACPI_EDGE_SENSITIVE
>> +                             : ACPI_LEVEL_SENSITIVE;
>> +            polarity = ((a.value >> 8) & 0x2) ? ACPI_ACTIVE_LOW
>> +                              : ACPI_ACTIVE_HIGH;
>> +            xen_events_irq = acpi_register_gsi(NULL, interrupt,
>> +                               trigger, polarity);
>> +        }
>> +    }
> 
> Can you invert the condition to remove one layer of indentation?
Sure, will update.

Thanks,
-- 
Shannon