Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932715AbcC3IJk (ORCPT ); Wed, 30 Mar 2016 04:09:40 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:41287 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932610AbcC3IJh (ORCPT ); Wed, 30 Mar 2016 04:09:37 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: iamjoonsoo.kim@lge.com X-Original-SENDERIP: 10.177.222.138 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Wed, 30 Mar 2016 17:11:35 +0900 From: Joonsoo Kim To: Geert Uytterhoeven Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Jesper Dangaard Brouer , Linux MM , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 02/11] mm/slab: remove BAD_ALIEN_MAGIC again Message-ID: <20160330081135.GB1678@js1304-P5Q-DELUXE> References: <1459142821-20303-1-git-send-email-iamjoonsoo.kim@lge.com> <1459142821-20303-3-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 990 Lines: 24 On Mon, Mar 28, 2016 at 10:58:38AM +0200, Geert Uytterhoeven wrote: > Hi Jonsoo, > > On Mon, Mar 28, 2016 at 7:26 AM, wrote: > > From: Joonsoo Kim > > > > Initial attemp to remove BAD_ALIEN_MAGIC is once reverted by > > 'commit edcad2509550 ("Revert "slab: remove BAD_ALIEN_MAGIC"")' > > because it causes a problem on m68k which has many node > > but !CONFIG_NUMA. In this case, although alien cache isn't used > > at all but to cope with some initialization path, garbage value > > is used and that is BAD_ALIEN_MAGIC. Now, this patch set > > use_alien_caches to 0 when !CONFIG_NUMA, there is no initialization > > path problem so we don't need BAD_ALIEN_MAGIC at all. So remove it. > > > > Signed-off-by: Joonsoo Kim > > I gave this a try on m68k/ARAnyM, and it didn't crash, unlike the previous > version that was reverted, so > Tested-by: Geert Uytterhoeven Thanks for testing!!! Thanks.