Subject: Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during
 init
To: Jisheng Zhang <jszhang@marvell.com>
References: <1458796269-6158-1-git-send-email-jszhang@marvell.com>
 <1458796269-6158-2-git-send-email-jszhang@marvell.com>
 <56F52502.3060308@linaro.org> <20160330151629.0b338365@xhacker>
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
        Catalin Marinas <Catalin.Marinas@arm.com>
From: Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <56FB89A8.90209@linaro.org>
Date: Wed, 30 Mar 2016 10:09:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160330151629.0b338365@xhacker>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1045
Lines: 32

On 03/30/2016 09:16 AM, Jisheng Zhang wrote:
> Hi Daniel,

[ ... ]

Added Lorenzo and Catalin.

>> Hi Jisheng,
>>
>> this should be handled in the arm_cpuidle_read_ops function.
>>
>
> Thanks for reviewing. After some consideration, I think this patch isn't correct
> There may be platforms which doesn't need the init member at all, although
> currently I don't see such platforms in mainline, So I'll drop this patch
> and send out one v2 only does the optimization.

There is an inconsistency between ARM and ARM64. The 'cpu_get_ops', the 
arm_cpuidle_read_ops from the ARM64 side, returns -EOPNOTSUPP when the 
init function is not there for cpuidle.

I don't think it is a problem, but as ARM/ARM64 are sharing the same 
cpuidle-arm.c driver it would make sense to unify the behavior between 
both archs.


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog