Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbcC3J6r (ORCPT ); Wed, 30 Mar 2016 05:58:47 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35914 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbcC3J6o (ORCPT ); Wed, 30 Mar 2016 05:58:44 -0400 MIME-Version: 1.0 In-Reply-To: <15b1936d307912ba12df7fa09ec3a7a80ac5fcef.1459174494.git.joabreu@synopsys.com> References: <15b1936d307912ba12df7fa09ec3a7a80ac5fcef.1459174494.git.joabreu@synopsys.com> Date: Wed, 30 Mar 2016 10:58:42 +0100 Message-ID: Subject: Re: [PATCH 1/3 v2] drm/i2c/adv7511: Add audio support From: Emil Velikov To: Jose Abreu Cc: linux-snps-arc@lists.infradead.org, "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , alsa-devel@alsa-project.org, devicetree , Jon Medhurst , Mark Rutland , broonie@kernel.org, Alexey Brodkin , lgirdwood@gmail.com, yitian.bu@tangramtek.com, wsa+renesas@sang-engineering.com, laurent.pinchart+renesas@ideasonboard.com, nariman@opensource.wolfsonmicro.com, Maruthi.Bayyavarapu@amd.com, Pawel Moll , Ian Campbell , Vineet.Gupta1@synopsys.com, buyitian@gmail.com, perex@perex.cz, tiwai@suse.com, Rob Herring , Kumar Gala , Alex Deucher , CARLOS.PALMINHA@synopsys.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1546 Lines: 42 Hi Jose, On 28 March 2016 at 15:36, Jose Abreu wrote: > This patch adds audio support for the ADV7511 HDMI transmitter > using ALSA SoC. > > The code was ported from Analog Devices linux tree from > commit 1770c4a1e32b ("Merge remote-tracking branch > 'xilinx/master' into xcomm_zynq"), which is available at: > - https://github.com/analogdevicesinc/linux/ > > The main core file was renamed from adv7511.c to adv7511_core.c > so that audio and video compile into a single adv7511.ko module > and to keep up with Analog Devices kernel tree. > > The audio can be disabled using menu-config so it is possible > to use only video mode. > > The HDMI mode is automatically started at boot and the audio > (when enabled) registers as a codec into ALSA. > > SPDIF DAI format was also added to ASoC as it is required > by adv7511 audio. > > Signed-off-by: Jose Abreu > --- > > No changes v1 -> v2. > > drivers/gpu/drm/i2c/Kconfig | 11 + > drivers/gpu/drm/i2c/Makefile | 2 + > drivers/gpu/drm/i2c/adv7511.c | 1024 ----------------------------------- > drivers/gpu/drm/i2c/adv7511.h | 41 ++ > drivers/gpu/drm/i2c/adv7511_audio.c | 310 +++++++++++ > drivers/gpu/drm/i2c/adv7511_core.c | 1005 ++++++++++++++++++++++++++++++++++ Please keep the file rename separate (and use -M flag when generating the patch) from the introduction of audio support. Having to check 1k LOC movement alongside the introduction of new one is a bit... suboptimal. Regards, Emil