Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954AbcC3K7S (ORCPT ); Wed, 30 Mar 2016 06:59:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:64637 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbcC3K7Q (ORCPT ); Wed, 30 Mar 2016 06:59:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,415,1455004800"; d="asc'?scan'208";a="774600208" From: Felipe Balbi To: changbin.du@intel.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Du\, Changbin" Subject: Re: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb In-Reply-To: <1459332836-11579-1-git-send-email-changbin.du@intel.com> References: <1459332836-11579-1-git-send-email-changbin.du@intel.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 30 Mar 2016 13:57:13 +0300 Message-ID: <87r3esp71y.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1978 Lines: 66 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, changbin.du@intel.com writes: > [ text/plain ] > From: "Du, Changbin" > > Actually, the function only clean one trb. So rename the function. > > Signed-off-by: Du, Changbin okay :-) > --- > drivers/usb/dwc3/gadget.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 3ac170f..f84be3d 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct dwc3 = *dwc) >=20=20 > /* ---------------------------------------------------------------------= ----- */ >=20=20 > -static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep *de= p, > +static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep *dep, I would rather just remove that 's' from the end so the function's name stays as __dwc3_cleanup_done_trb() ;-) Care to do that ? thanks =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW+7EKAAoJEIaOsuA1yqREUFAP/jUZghUuG6HgoP74abQjnedU mULI+DlXz5QAglpuzXKpTO8Ecqn2DkgOB1XjOSDdN2fHYlNbXGhGx8XXm88URxCr 0snwMpiks1lGb7GMFI4ckoylbDgDD9TlC6glR1L9LfzeBXaj+udaZtYaX++XVMjb OfwHDJOCvwTioIgxBSbmjUzDaXqt1i2U+LtCHEqh8oqi4+rGf06srL7XNE+T4p/T GQudWPKUQ/0CGFDtVMtw+rtvbWA3qyvPmPSmsSLZjnwrZCJSJTglDCno2/OxFvXA po2B9jBImAhSN/GFlaD9CsoxwmFa1MYiZI1R2USo3mfHThKz737FAKoH720OgvTL 7RlWrclSlj8xnALJ7HSG/sO6ZJje2Ub37Z9RHailt6WZL0YYct3OReRTIQAcfOmy I/VBAwI8CXLo46oXFqU/gF2XPVuZLOwU1ilmVI4BG54LMN3rWUzdXy1tn9WPe1d2 dfng83qvzS/5qjLR/ljIP73BwH97D6PUjNCg8ALBsAWbJhKTwPkHfGNpAB0ocRTe 1VTffWUg98lpD9+lV4guJJSxSIByR//kGwTxRucPX2r3VjFmSliS/E3bjZkfTOgc U1Hs1mgJK53RtaYIOi7hNyIWrJFrgBNRmRxSBADac50osFIQ5HtrZlomLzdnEfn7 +I0NyQgS7gXdGQxCcjBO =cNaE -----END PGP SIGNATURE----- --=-=-=--