Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbcC3LFs (ORCPT ); Wed, 30 Mar 2016 07:05:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:63960 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbcC3LFr convert rfc822-to-8bit (ORCPT ); Wed, 30 Mar 2016 07:05:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,415,1455004800"; d="scan'208";a="944393633" From: "Du, Changbin" To: Felipe Balbi CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb Thread-Topic: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb Thread-Index: AQHRim5ltLnnxHB/qU2NenJFQ795159xStuAgACHEKA= Date: Wed, 30 Mar 2016 11:04:03 +0000 Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A05CDF3AF@SHSMSX103.ccr.corp.intel.com> References: <1459332836-11579-1-git-send-email-changbin.du@intel.com> <87r3esp71y.fsf@intel.com> In-Reply-To: <87r3esp71y.fsf@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmE5ZGZlMzctOGUxMC00NWNjLTkyMTEtZTNmOTEwYjI0YzFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRzMVdhbU9xTDR1bXdOZCs2VXlPU28xc1YwWXdpNEl4YzU1a0ZkRXFBXC9zPSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 24 > > @@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct > dwc3 *dwc) > > > > /* -------------------------------------------------------------------------- */ > > > > -static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep > *dep, > > +static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep > *dep, > > I would rather just remove that 's' from the end so the function's name > stays as __dwc3_cleanup_done_trb() ;-) > > Care to do that ? > > thanks > > -- > Balbi IMO, "one_trb" is a little more clear. But both is okay for me. :) Thanks, Du, Changbin