Subject: Re: [PATCH v3 0/2] mmc: dw_mmc: controller reset support
To: Guodong Xu <guodong.xu@linaro.org>, jh80.chung@samsung.com,
        --to=robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        ulf.hansson@linaro.org
References: <1459322696-29919-1-git-send-email-guodong.xu@linaro.org>
Cc: shawn.lin@rock-chips.com, =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
From: Shawn Lin <shawn.lin@rock-chips.com>
Message-ID: <56FBBC41.5080104@rock-chips.com>
Date: Wed, 30 Mar 2016 19:45:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <1459322696-29919-1-git-send-email-guodong.xu@linaro.org>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1113
Lines: 31

+ Heiko
On 2016/3/30 15:24, Guodong Xu wrote:
> mmc controller registers may in abnormal state if mmc is used in
> bootloader, eg. to load kernel from eMMC. Some controllers cann't
> clear their registers when clk is set. They use dedicated reset
> logics to do this.
>
> In this patch, a 'resets' property is added into dw_mmc dts
> node. When driver does parse_dt and probe, it calls reset API to
> deassert the 'reset' of dw_mmc host controller. When probe error or
> remove, it calls reset API to assert it.
>
> Chip vendor's actual reset logics is implemented in reset driver, not
> in dw_mmc code.
>
> Please also refer to Documentation/devicetree/bindings/reset/reset.txt
>
> Guodong Xu (2):
>    Documentation: synopsys-dw-mshc: add binding for resets
>    mmc: dw_mmc: add resets support to dw_mmc
>
>   .../devicetree/bindings/mmc/synopsys-dw-mshc.txt     |  4 ++++
>   drivers/mmc/host/dw_mmc.c                            | 20 +++++++++++++++++++-
>   include/linux/mmc/dw_mmc.h                           |  6 ++++--
>   3 files changed, 27 insertions(+), 3 deletions(-)
>


-- 
Best Regards
Shawn Lin