Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154AbcC3MTp (ORCPT ); Wed, 30 Mar 2016 08:19:45 -0400 Received: from sauhun.de ([89.238.76.85]:43004 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753079AbcC3MTn (ORCPT ); Wed, 30 Mar 2016 08:19:43 -0400 Date: Wed, 30 Mar 2016 14:19:34 +0200 From: Wolfram Sang To: Julia Lawall Cc: linux-kernel@vger.kernel.org, Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr Subject: Re: [PATCH] scripts: coccinelle: remove check to move constants to right Message-ID: <20160330121934.GA9329@katana> References: <1458409079-4669-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1821 Lines: 50 --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote: > On Sat, 19 Mar 2016, Wolfram Sang wrote: >=20 > > The header mentions this check depends on personal taste. I agree. > > Running coccicheck on patches before I apply them, this SmPL produced > > enough false positives for me that I'd rather see it removed. >=20 > An improvement is coming up, that should be more acceptable. However,=20 > it's being held up by the need for some bug fixes in Coccinelle. A=20 > release of Coccinelle is planned for the beginning of April. Perhaps=20 > it is just as well to just remove this version for now. >=20 > Acked-by: Julia Lawall Michal, can we have that in v4.6 please? The false positives are annoying... Thanks, Wolfram --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW+8RWAAoJEBQN5MwUoCm2xAsP/R9TLggjwBkoLyUSGF9F8Ox6 n8YTUTBXFfljS/fQHJgCPh8A64zhMlXw3rGcZY2kXIIqBQm2W8QcStWj7sKE8RD7 z5vFinXNJOdsakTXOIvwLHt69iSGkMKX4T698CF1V2E+L1EmI/Oi9t9y+RuPGFLQ q66ZyULwAE5iYNTx4ZBQRS84o86PMqRKWDE0UvDGnL/GDCQglHLokcDlGI0A5Zlm LyHxdMF763rK04V4FFXy42+8ea8Gh2gEJoeS5uxo+Llxm+l3bPDRcGdnpnKjJBh7 PjDmpEAQL/k/lQe1mx7gAANY2j86avPkGWtN4tTN8LbD1gFdPs5qZcszJSNOPPdb 79b5B45WjmkU5LpQ0qjzTQpn9wfp4QDoZbC6PjXj++0VBI9Kx+AMEbqG5kIPYfDV SqzyYswYQ8gu5jA2hGrsxI8jW6vaA6cfcB43CrqG/brw+kN4F4R/H8kpVOaar8MO Fhp/HWdH/mvv6qbQRLxfNRyVVim7XDnClV9HgXHf//Ty4Uxa/vwtVB144geCsvV/ kuh/pSxFxvyUVsTraMCaCZtTKfM8qGTHrwShhDPW17XYHlyNBbay7aDh3sk3IaFm J/8XDHnPqgbKu21clI/aly8jistI7ACUKT9fKUN2tOU+nKccWGRLDLKKM8Ql5NC/ 5Om500jrw/dfBOJjiUCf =X5sQ -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C--