Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753096AbcC3MXY (ORCPT ); Wed, 30 Mar 2016 08:23:24 -0400 Received: from smtprelay0047.hostedemail.com ([216.40.44.47]:36973 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751905AbcC3MXX (ORCPT ); Wed, 30 Mar 2016 08:23:23 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:69:355:379:541:968:973:988:989:1260:1345:1437:1534:1541:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:3138:3139:3140:3141:3142:3353:3865:3866:3867:3868:3870:3871:3872:3874:4384:4605:5007:6261:10004:10848:11658:11914:12296:12517:12519:12555:12679:13069:13161:13229:13311:13357:14096:14394:14721:21080:30054:30070,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: war16_5774f3c26e662 X-Filterd-Recvd-Size: 2081 From: Joe Perches To: jfs-discussion@lists.sourceforge.net Cc: Dave Kleikamp , linux-kernel@vger.kernel.org Subject: [PATCH 0/3] jfs: logging neatening Date: Wed, 30 Mar 2016 05:23:15 -0700 Message-Id: X-Mailer: git-send-email 2.8.0.rc4.16.g56331f8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 38 This patchset fixes the uses of jfs_info, jfs_warn and jfs_err that have terminating newlines and a couple other trivialities to make the logging a bit more consistent. There is a difference in use between jfs_error and the other jfs_info, jfs_warn, and jfs_err logging macros. jfs_error is more like the rest of the kernel and requires a newline as the last character of the format. The jfs_info, jfs_warn, and jfs_err macros add the terminating newline to the format so the uses do not require them. It is a habituated style for many people to add the terminating newline for many people and this difference in use between the various macro styles causes trivial defects in logging output. It might be better if the jfs_info, jfs_warn, and jfs_err macros were changed to require a newline termination and the uses changed to include the newline, but that's a larger change. Joe Perches (3): jfs: Remove terminating newlines from jfs_info, jfs_warn, jfs_err uses jfs: Remove unnecessary line continuations and terminating newlines jfs: Coalesce some formats fs/jfs/inode.c | 4 ++-- fs/jfs/jfs_discard.c | 6 ++---- fs/jfs/jfs_dtree.c | 10 ++++------ fs/jfs/jfs_imap.c | 3 +-- fs/jfs/jfs_inode.c | 2 +- fs/jfs/jfs_logmgr.c | 14 ++++++-------- fs/jfs/jfs_txnmgr.c | 21 +++++++++------------ fs/jfs/namei.c | 4 ++-- fs/jfs/super.c | 4 ++-- 9 files changed, 29 insertions(+), 39 deletions(-) -- 2.8.0.rc4.16.g56331f8