Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753383AbcC3My3 (ORCPT ); Wed, 30 Mar 2016 08:54:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:46436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbcC3My1 (ORCPT ); Wed, 30 Mar 2016 08:54:27 -0400 MIME-Version: 1.0 In-Reply-To: <20160327055012.GD8929@tuxbot> References: <1458762366-9233-1-git-send-email-srinivas.kandagatla@linaro.org> <1458762484-9768-1-git-send-email-srinivas.kandagatla@linaro.org> <20160327055012.GD8929@tuxbot> From: Rob Herring Date: Wed, 30 Mar 2016 07:54:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 10/12] ARM: dts: dragonboard-600c: Add on board leds support To: Bjorn Andersson Cc: Srinivas Kandagatla , Andy Gross , linux-arm-msm , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-soc@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 35 On Sun, Mar 27, 2016 at 12:50 AM, Bjorn Andersson wrote: > On Wed 23 Mar 12:48 PDT 2016, Srinivas Kandagatla wrote: > >> This patch adds support to 4 user leds, wlan and bt led on board. >> >> Signed-off-by: Srinivas Kandagatla > > I'm not fond of the overly complicated names; and I think it should at > least be shortened to "db600c:...". These names are exposed to userspace. They should be the same across all 96boards. Same goes for UART numbering and I2C bus labels on the connector. > Tested this on my DB600c, seems to work, except the WiFi/BT triggers, > see comments below. > >> + leds { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&user_leds>, <&mpp_leds>; >> + >> + compatible = "gpio-leds"; >> + >> + led@1 { unit-address w/o reg property will warn on new dtc. I'd suggest something like "userX-led". >> + label = "dragonboard-600c:green:user1"; >> + gpios = <&tlmm_pinmux 3 GPIO_ACTIVE_HIGH>; >> + linux,default-trigger = "heartbeat"; >> + default-state = "off"; >> + };