Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbcC3N3n (ORCPT ); Wed, 30 Mar 2016 09:29:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:44924 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753874AbcC3N3m (ORCPT ); Wed, 30 Mar 2016 09:29:42 -0400 Subject: Re: [GIT PULL] kconfig changes for v4.6-rc1 To: Geert Uytterhoeven , Al Viro References: <20160324205119.GA11597@pobox.suse.cz> Cc: Linus Torvalds , Jan Beulich , linux-kbuild , "linux-kernel@vger.kernel.org" From: Michal Marek Message-ID: <56FBD4C3.5090701@suse.cz> Date: Wed, 30 Mar 2016 15:29:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1166 Lines: 37 On 2016-03-25 10:03, Geert Uytterhoeven wrote: > On Fri, Mar 25, 2016 at 9:54 AM, Geert Uytterhoeven >>> Al Viro (1): >>> unbreak allmodconfig KCONFIG_ALLCONFIG=... >> >> I can now indeed drop the >> >> CONFIG_MODULES=y >> >> line from my >> >> allmod.config >> >> However, this fix has the side-effect of enabling CONFIG_MODULES silently for >> >> make allyesconfig KCONFIG_ALLCONFIG=1 >> >> Adding an explicit >> >> CONFIG_MODULES=n >> >> to the allyes.config file fixes that. >> >> IMHO CONFIG_MODULES should default to y when using allmodconfig, and >> default to n when using allyesconfig. > > Hmm, it seems plain "make allyesconfig" also enables CONFIG_MODULES, and > makes many options modular. Is that intentional, especially the latter? allyesconfig builds everything into the kernel, so why exclude the module loader. And there are a few modules with a 'depends on m' statement, either because this is test code in samples/ which is not even considered when linking the kernel, or there is some "issue" when the code is built-in. The statement might also be completely bogus, but that's not a job of allyesconfig to decide. Michal