Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753770AbcC3Ngm (ORCPT ); Wed, 30 Mar 2016 09:36:42 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:34660 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753645AbcC3Ngk (ORCPT ); Wed, 30 Mar 2016 09:36:40 -0400 Message-ID: <1459344923.2505.35.camel@pengutronix.de> Subject: Re: [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in error path From: Philipp Zabel To: Doug Anderson Cc: Russell King , Daniel Kurtz , "open list:ARM/Rockchip SoC..." , John Keeping , "dri-devel@lists.freedesktop.org" , Mark Yao , "linux-kernel@vger.kernel.org" , David Airlie , Heiko Stuebner Date: Wed, 30 Mar 2016 15:35:23 +0200 In-Reply-To: References: <1457388054-23077-1-git-send-email-dianders@chromium.org> <1457388054-23077-2-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 41 Hi Doug, Am Montag, den 28.03.2016, 08:14 -0700 schrieb Doug Anderson: > Hi, > > On Mon, Mar 7, 2016 at 2:00 PM, Douglas Anderson wrote: > > The drm_encoder_cleanup() was missing both from the error path of > > dw_hdmi_imx_bind(). This caused a crash when slub_debug was > > enabled and we ended up deferring probe of HDMI at boot. > > > > This call isn't needed from unbind() because if dw_hdmi_bind() returns > > no error then it takes over the job of freeing the encoder (in > > dw_hdmi_unbind). > > > > Signed-off-by: Douglas Anderson > > --- > > Changes in v2: > > - IMX patch new in v2 > > > > drivers/gpu/drm/imx/dw_hdmi-imx.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > Mark picked up: > > [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path > [PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup > [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata() > > ...for Rockchip, as you can see at > . > > Does someone want to pick up: > [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in error path > [PATCH v2 5/5] drm/imx: dw_hdmi: Don't call platform_set_drvdata() > > Thanks! Thank you for the reminder, both patches applied. regards Philipp