Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753701AbcC3NkN (ORCPT ); Wed, 30 Mar 2016 09:40:13 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:4442 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753488AbcC3Njn (ORCPT ); Wed, 30 Mar 2016 09:39:43 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 30 Mar 2016 06:38:26 -0700 Message-ID: <56FBD4A3.7080208@nvidia.com> Date: Wed, 30 Mar 2016 18:59:07 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Bjorn Andersson CC: Mark Brown , Bjorn Andersson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Liam Girdwood , "Bjorn Andersson" , Stephen Warren , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gandhar Dighe , "Stuart Yates" Subject: Re: [PATCH 1/2] regulator: DT: Add support to scale ramp delay based on platform behavior References: <1456756829-2277-1-git-send-email-ldewangan@nvidia.com> <20160229174751.GQ21240@tuxbot> <20160301022326.GC18327@sirena.org.uk> <56D5111E.6090606@nvidia.com> <20160302033833.GV18327@sirena.org.uk> <56D65F7E.3090907@nvidia.com> <20160302043506.GC18327@sirena.org.uk> <56E81103.8010903@nvidia.com> <56ED0F58.7060005@nvidia.com> In-Reply-To: <56ED0F58.7060005@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 40 On Saturday 19 March 2016 02:05 PM, Laxman Dewangan wrote: > > On Saturday 19 March 2016 10:01 AM, Bjorn Andersson wrote: >> On Tue, Mar 15, 2016 at 6:41 AM, Laxman Dewangan >> wrote: >>> >>> >> Generally the device driver should describe the PMIC and the device >> tree should describe the board. So the Maxim's numbers should (if >> specified at all) go into the driver and the measures/calculated >> characteristics for your board should be specified in the dt. >> >> The ramp properties in the generic regulator binding is used to inform >> the OS about the board's ramp properties. >> >> >> If I understand you correctly the Maxim PMIC can be configured to >> drive the change at different speed, this should be configured through >> a Maxim specific property. It should not reuse the generic properties >> for ramp delays. >> > > Ramp delay configurations are seen on other vendor's PMIC devices also. > Therefore, I like o me generic property rather than specific to Maxim. > Parsing can be done in the core framework and applied during setting > machine constraints. Any comment on this approach? Like to add property as "regulator-device-ramp-delay" which will be used for PMIC configuration and regulator-ramp-delay will be used for delay calculation. This is case when advertised ramp delay does not match with the platform measured ramp delay. If regulator-device-ramp-delay is not provided from platform then regulator-ramp-delay will be used for PMIC configuration as well as for the delay calculation. This is case when advertised ramp delay match with the platform measured ramp delay.