Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS
 types
To: Stephen Boyd <stephen.boyd@linaro.org>, Mark Brown <broonie@kernel.org>
References: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org>
Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, David Collins <collinsd@codeaurora.org>
From: Georgi Djakov <georgi.djakov@linaro.org>
Message-ID: <56FBE45B.4030709@linaro.org>
Date: Wed, 30 Mar 2016 17:36:11 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 22

On 03/30/2016 01:58 AM, Stephen Boyd wrote:
> Only the FT SMPS type regulators have slewing supported in the
> driver, but all types of SMPS regulators need the same support.
> The only difference is that some SMPS regulators don't have a
> step size and the step delay is typically 20, not 8. Luckily, the
> step size reads as 0 for the non-FT types, so we can always read
> that, but we need to detect which type of regulator we're using
> to figure out what step delay to use. Make these minor
> adjustments to the slew rate calculations and add support for the
> delay function to the appropriate regulator ops.
> 
> Reported-by: Georgi Djakov <georgi.djakov@linaro.org>
> Cc: David Collins <collinsd@codeaurora.org>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>

Thanks for the patch! I have verified it by applying this one
on top: https://lkml.org/lkml/2016/3/30/381

Tested-by: Georgi Djakov <georgi.djakov@linaro.org>

BR,
Georgi