Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754348AbcC3P37 (ORCPT ); Wed, 30 Mar 2016 11:29:59 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:34392 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753005AbcC3P35 (ORCPT ); Wed, 30 Mar 2016 11:29:57 -0400 From: Sudip Mukherjee To: Ralf Baechle Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Sudip Mukherjee , Antony Pavlov Subject: [PATCH] MIPS: ath79: fix build failure Date: Wed, 30 Mar 2016 16:29:49 +0100 Message-Id: <1459351789-24544-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 42 The ath79_defconfig build of mips was faling with the errors: arch/mips/ath79/setup.c: In function 'plat_mem_setup': arch/mips/ath79/setup.c:226:20: error: invalid storage class for function 'ath79_of_plat_time_init' static void __init ath79_of_plat_time_init(void) ^ arch/mips/ath79/setup.c:226:1: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] static void __init ath79_of_plat_time_init(void) ^ arch/mips/ath79/setup.c:284:20: error: invalid storage class for function 'ath79_setup' static __init int ath79_setup(void) ^ arch/mips/ath79/setup.c:299:1: error: initializer element is not constant arch_initcall(ath79_setup); It turns out to be a simple error of a missed closing brace. Fixes: f63ba725caa7 ("MIPS: ath79: Disable platform code for OF boards.") Cc: Antony Pavlov Signed-off-by: Sudip Mukherjee --- Build log of next-20160330 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/119417999 arch/mips/ath79/setup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/ath79/setup.c b/arch/mips/ath79/setup.c index 897f49a..e0ff6f3 100644 --- a/arch/mips/ath79/setup.c +++ b/arch/mips/ath79/setup.c @@ -214,6 +214,7 @@ void __init plat_mem_setup(void) AR71XX_PLL_SIZE); ath79_detect_sys_type(); ath79_ddr_ctrl_init(); + } detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); /* OF machines should use the reset driver */ -- 2.1.4