Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754789AbcC3P5K (ORCPT ); Wed, 30 Mar 2016 11:57:10 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42034 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbcC3P5H (ORCPT ); Wed, 30 Mar 2016 11:57:07 -0400 Subject: Re: [PATCH 0/3] jfs: logging neatening To: Joe Perches , JFS Discussion References: Cc: linux-kernel@vger.kernel.org From: Dave Kleikamp Message-ID: <56FBF747.60306@oracle.com> Date: Wed, 30 Mar 2016 10:56:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1953 Lines: 48 On 03/30/2016 07:23 AM, Joe Perches wrote: > This patchset fixes the uses of jfs_info, jfs_warn and jfs_err that > have terminating newlines and a couple other trivialities to make > the logging a bit more consistent. These patches look good. I'm pushing them out to the -next build. > There is a difference in use between jfs_error and the other > jfs_info, jfs_warn, and jfs_err logging macros. jfs_error is more > like the rest of the kernel and requires a newline as the last > character of the format. > > The jfs_info, jfs_warn, and jfs_err macros add the terminating > newline to the format so the uses do not require them. I think there's an argument for both ways of doing it. I'm sure I had my reasons for automatically adding the newline back when I implemented those macros. (They probably should be inline functions, but that's another issue.) > It is a habituated style for many people to add the terminating > newline for many people and this difference in use between the > various macro styles causes trivial defects in logging output. > > It might be better if the jfs_info, jfs_warn, and jfs_err macros > were changed to require a newline termination and the uses changed > to include the newline, but that's a larger change. Yeah, these patches are the obvious improvement, without changing anything from a design standpoint. > > Joe Perches (3): > jfs: Remove terminating newlines from jfs_info, jfs_warn, jfs_err uses > jfs: Remove unnecessary line continuations and terminating newlines > jfs: Coalesce some formats > > fs/jfs/inode.c | 4 ++-- > fs/jfs/jfs_discard.c | 6 ++---- > fs/jfs/jfs_dtree.c | 10 ++++------ > fs/jfs/jfs_imap.c | 3 +-- > fs/jfs/jfs_inode.c | 2 +- > fs/jfs/jfs_logmgr.c | 14 ++++++-------- > fs/jfs/jfs_txnmgr.c | 21 +++++++++------------ > fs/jfs/namei.c | 4 ++-- > fs/jfs/super.c | 4 ++-- > 9 files changed, 29 insertions(+), 39 deletions(-) >