Date: Wed, 30 Mar 2016 09:50:30 -0700
From: Shaohua Li <shli@fb.com>
To: Christoph Hellwig <hch@infradead.org>
CC: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <axboe@fb.com>, <Kernel-team@fb.com>, "4.2+" <stable@vger.kernel.org>,
        Ming Lei <ming.lei@canonical.com>, <kent.overstreet@gmail.com>
Subject: Re: [PATCH] block: don't make BLK_DEF_MAX_SECTORS too big
Message-ID: <20160330165019.GC3552828@devbig084.prn1.facebook.com>
References: <21cf85d32278bbe5acbc3def0a6db75db98a2670.1459269590.git.shli@fb.com>
 <20160329211833.GA18532@infradead.org>
 <20160329220053.GA1716708@devbig084.prn1.facebook.com>
 <20160330065151.GA29666@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20160330065151.GA29666@infradead.org>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1036
Lines: 20

On Tue, Mar 29, 2016 at 11:51:51PM -0700, Christoph Hellwig wrote:
> On Tue, Mar 29, 2016 at 03:01:10PM -0700, Shaohua Li wrote:
> > The problem is bcache allocates a big bio (with bio_alloc). The bio is
> > split with blk_queue_split, but it isn't split to small size because
> > queue limit. the bio is cloned later in md, which uses bio_alloc_bioset.
> > bio_alloc_bioset itself can't allocate big size bio.
> 
> bcache should be fixed to not allocate larger than allowed bios then.
> And handling too large arguments to bio_alloc_bioset is still useful to
> avoid the checks in the callers and make it robust.

Doesn't this conflict the goal of arbitrary bio size? I think nothing is
wrong in bcache side. The caller can allocate any size of bio, the block
layer will split the bio into proper size according to block layer
limitatio and driver limitation. As long as bio_split can do the right
job, caller of bio allo is good. Fixing bcache is in the opposite side.
I'm Cc Kent to check if he wants to fix bcache.

Thanks,
Shaohua