Subject: Re: [PATCH] regulator: Fix deadlock during regulator registration
To: Mark Brown <broonie@kernel.org>
References: <1459354153-6352-1-git-send-email-jonathanh@nvidia.com>
 <20160330161831.GE2350@sirena.org.uk> <56FC02CD.60107@nvidia.com>
 <20160330170053.GK2350@sirena.org.uk>
CC: Liam Girdwood <lgirdwood@gmail.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <56FC0FAF.3010200@nvidia.com>
Date: Wed, 30 Mar 2016 18:41:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160330170053.GK2350@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1200
Lines: 31


On 30/03/16 18:00, Mark Brown wrote:
> * PGP Signed by an unknown key
> 
> On Wed, Mar 30, 2016 at 05:46:05PM +0100, Jon Hunter wrote:
> 
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.
> 
>>> Please don't paste entire backlogs into changelogs, they're *enormous*,
>>> mostly noise and obscure any actual content that's in there through
>>> denial of service.  If they're useful then include edited subsets that
>>> highlight the relevant sections of the backtrace so your changelog is
>>> more legible.
> 
>> Ok, no problem. Are you happy with the patch otherwise? If so, do you
>> want me to resend or do you wish to trim the backlog? I think that
> 
> I haven't reviwed it yet.
> 
>> this part is interesting ...
> 
> I'm really getting nothing at all from this, all it really does is point
> to the call site but that's already much more clearly identified in the
> changelog.  We certainly don't need to know which driver called this.

Ok, fine with me. If you are happy with the actual change, feel free to
remove the backlog or I can re-send if you wish.

Jon