Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754488AbcC3Rp2 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Mar 2016 13:45:28 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57318 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752794AbcC3Rp0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Mar 2016 13:45:26 -0400
Date: Wed, 30 Mar 2016 10:44:58 -0700
From: Mark Brown <broonie@kernel.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Baolin Wang <baolin.wang@linaro.org>, gregkh@linuxfoundation.org,
        sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org,
        peter.chen@freescale.com, stern@rowland.harvard.edu,
        r.baldyga@samsung.com, yoshihiro.shimoda.uh@renesas.com,
        lee.jones@linaro.org, ckeepax@opensource.wolfsonmicro.com,
        patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org,
        linux-usb@vger.kernel.org, device-mainlining@lists.linuxfoundation.org,
        linux-kernel@vger.kernel.org
Message-ID: <20160330174458.GP2350@sirena.org.uk>
References: <cover.1458128215.git.baolin.wang@linaro.org>
 <11ce6df3eb8a95cfed26f3321f15c98a934db642.1458128215.git.baolin.wang@linaro.org>
 <87h9foqnur.fsf@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Uc2nn8srCdMFAHlk"
Content-Disposition: inline
In-Reply-To: <87h9foqnur.fsf@intel.com>
X-Cookie: If anything can go wrong, it will.
User-Agent: Mutt/1.5.24 (2015-08-30)
X-SA-Exim-Connect-IP: 64.55.107.4
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1396
Lines: 43


--Uc2nn8srCdMFAHlk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 30, 2016 at 01:09:00PM +0300, Felipe Balbi wrote:
> Baolin Wang <baolin.wang@linaro.org> writes:

> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > +#include <linux/of_address.h>
> > +#include <linux/platform_device.h>

> not very nice to depend on either of or platform_device here. What about
> PCI-based devices ?

The header inclusion shouldn't be conditional though.  But looking at
the patch I can't immediately see any use of these in the code anyway.

> > +static DEVICE_ATTR_RW(sdp_limit);

> why RW ? Who's going to use these ? Also, you're not documenting this
> new sysfs file.

If they end up not writeable should we just remove them entirely since
they should just be the spec values?

--Uc2nn8srCdMFAHlk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJW/BCRAAoJECTWi3JdVIfQVRAH/04NkweSyILzir/w7glvhIQR
LIgVc2KvRQ0637Ce2NKDJ8XedXvY7642E8tVMT1ieFd/DaIk0VwaUolmcmw0c4pi
4kbtoWy9YYKi1K72oTUbFnEbuZgiNZTXnY8VEFmbnRy9yJOznrnc3dt3CwHw1Eqx
QpoeGEiZLD9p+uMOw2J01KQKfatLkVKYPstNz0vkFTb+ibLMzurEe0X99Fd3iPVL
niiH1+ExzmnjkAQuTCZ6F/AJSRMYIQr0I8RvWrr2iwGXR+4hTNlpj01g1VLHiMPq
Xy//VXMbcM2HmCgMdMFBIeBflwBdiMZnVswzD9mlQUOlNqMVCyxSOk6cIrK3JjE=
=6eD0
-----END PGP SIGNATURE-----

--Uc2nn8srCdMFAHlk--