Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To: Georgi Djakov <georgi.djakov@linaro.org>,
        "Mark Brown" <broonie@kernel.org>
From: Stephen Boyd <stephen.boyd@linaro.org>
In-Reply-To: <56FBE45B.4030709@linaro.org>
Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        "David Collins" <collinsd@codeaurora.org>
References: <1459292320-1996-1-git-send-email-stephen.boyd@linaro.org>
 <56FBE45B.4030709@linaro.org>
Message-ID: <20160330180933.5175.90898@sboyd-linaro>
User-Agent: alot/0.3.7
Subject: Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types
Date: Wed, 30 Mar 2016 11:09:33 -0700
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1086
Lines: 23

Quoting Georgi Djakov (2016-03-30 07:36:11)
> On 03/30/2016 01:58 AM, Stephen Boyd wrote:
> > Only the FT SMPS type regulators have slewing supported in the
> > driver, but all types of SMPS regulators need the same support.
> > The only difference is that some SMPS regulators don't have a
> > step size and the step delay is typically 20, not 8. Luckily, the
> > step size reads as 0 for the non-FT types, so we can always read
> > that, but we need to detect which type of regulator we're using
> > to figure out what step delay to use. Make these minor
> > adjustments to the slew rate calculations and add support for the
> > delay function to the appropriate regulator ops.
> > 
> > Reported-by: Georgi Djakov <georgi.djakov@linaro.org>
> > Cc: David Collins <collinsd@codeaurora.org>
> > Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> 
> Thanks for the patch! I have verified it by applying this one
> on top: https://lkml.org/lkml/2016/3/30/381
> 
> Tested-by: Georgi Djakov <georgi.djakov@linaro.org>
> 

Thanks for testing. I'll pick up the rest on the other thread.