Date: Wed, 30 Mar 2016 11:32:07 -0700
From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: Georgi Djakov <georgi.djakov@linaro.org>, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Message-ID: <20160330183207.GR2350@sirena.org.uk>
References: <1459347792-13515-1-git-send-email-georgi.djakov@linaro.org>
 <20160330173658.GN2350@sirena.org.uk>
 <20160330181709.5175.51228@sboyd-linaro>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="99FKeZQ5IARcBmLz"
Content-Disposition: inline
In-Reply-To: <20160330181709.5175.51228@sboyd-linaro>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [PATCH] regulator: Support ramp-up delay for drivers with
 get_voltage()
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1741
Lines: 41


--99FKeZQ5IARcBmLz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 30, 2016 at 11:17:09AM -0700, Stephen Boyd wrote:

> This is for the qcom spmi regulator driver. I seem to have put in the
> set_voltage_time_sel op but missed the fact that the regulator core
> wasn't calling that op to find out how much time to delay. So we have
> raw voltage set and get ops and this selector based delay op.

> Do we need to change the ops to be selector based if we want the
> regulator core to delay after changing voltages? Or do we need to put
> the delay directly into the set_voltage() op in the driver?

You need a consistent set of operations.  If you want to use raw
voltages you need to add a raw voltage interface for getting the delay,
not mix selector and non-selector interfaces otherwise we'll run into
problems.  It is not sensible to expect a driver that does not use
selectors to implement selectors for some operations, if a driver *does*
use selectors then it should do so consistently.  The latter is probably
the more sensible option for this driver since it does have a list
operation so does understand selectors.

--99FKeZQ5IARcBmLz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJW/BuiAAoJECTWi3JdVIfQJT8H/2+IuX4dQ1RrbRKtc4+c7f8G
qyMaINkEp2H9Km3NFLp6rhgGAidWU1avcqlNRMBcTvMTCkH/Ccj6p8KEzpgVhilw
6AXMrUNpm7ZfuNVzoIfgBvIDmNMQ1KPXrjxtPK+ujWN7ukLHd4v6O4cmGs5x0Q0j
vlxmlVzMY8PwUH6ElZRWGUImkbmApkcTDGXX795ET5eJVCASCmS7OGocGK1Q2WyH
FNp94FWEKHaVOXn9TVa1rE9NWltVxt4nBBLzmLLGxkTZHoN5UJDIvRdbp//EPVZF
lqLFfz51hgFP4PpJUywrko87HkOj7SsjFnVUdmO7QU04y0vfnEw6zOFz55YFjNk=
=hdPj
-----END PGP SIGNATURE-----

--99FKeZQ5IARcBmLz--