Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753642AbcC3TNp (ORCPT ); Wed, 30 Mar 2016 15:13:45 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:32813 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbcC3TNn convert rfc822-to-8bit (ORCPT ); Wed, 30 Mar 2016 15:13:43 -0400 Date: Wed, 30 Mar 2016 22:13:29 +0300 From: Antony Pavlov To: Sudip Mukherjee Cc: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: ath79: fix build failure Message-Id: <20160330221329.25ca0849d782e55c0564f139@gmail.com> In-Reply-To: <1459351789-24544-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1459351789-24544-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Sylpheed 3.5.0beta3 (GTK+ 2.24.25; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2243 Lines: 62 On Wed, 30 Mar 2016 16:29:49 +0100 Sudip Mukherjee wrote: > The ath79_defconfig build of mips was faling with the errors: > > arch/mips/ath79/setup.c: In function 'plat_mem_setup': > arch/mips/ath79/setup.c:226:20: error: invalid storage class for function 'ath79_of_plat_time_init' > static void __init ath79_of_plat_time_init(void) > ^ > arch/mips/ath79/setup.c:226:1: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] > static void __init ath79_of_plat_time_init(void) > ^ > arch/mips/ath79/setup.c:284:20: error: invalid storage class for function 'ath79_setup' > static __init int ath79_setup(void) > ^ > arch/mips/ath79/setup.c:299:1: error: initializer element is not constant > arch_initcall(ath79_setup); > > It turns out to be a simple error of a missed closing brace. > > Fixes: f63ba725caa7 ("MIPS: ath79: Disable platform code for OF boards.") > Cc: Antony Pavlov > Signed-off-by: Sudip Mukherjee > --- > > Build log of next-20160330 is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/119417999 > > arch/mips/ath79/setup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/ath79/setup.c b/arch/mips/ath79/setup.c > index 897f49a..e0ff6f3 100644 > --- a/arch/mips/ath79/setup.c > +++ b/arch/mips/ath79/setup.c > @@ -214,6 +214,7 @@ void __init plat_mem_setup(void) > AR71XX_PLL_SIZE); > ath79_detect_sys_type(); > ath79_ddr_ctrl_init(); > + } > > detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); > /* OF machines should use the reset driver */ It is very strange because my original patch has this closing brace. Please see my original patch https://www.linux-mips.org/archives/linux-mips/2016-03/msg00267.html Also I suppose that we have no need in detect_memory_region() if we use devicetree, e.g. ath79_detect_sys_type(); ath79_ddr_ctrl_init(); + detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); + } - detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); --? Best regards, ? Antony Pavlov