Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259AbcC3Tsp (ORCPT ); Wed, 30 Mar 2016 15:48:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37526 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbcC3Tso (ORCPT ); Wed, 30 Mar 2016 15:48:44 -0400 Date: Wed, 30 Mar 2016 15:48:42 -0400 (EDT) Message-Id: <20160330.154842.1616404973583316987.davem@davemloft.net> To: colin.king@canonical.com Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, everest-linux-l2@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qed: initialize return rc to avoid returning garbage From: David Miller In-Reply-To: <1459270850-16177-1-git-send-email-colin.king@canonical.com> References: <1459270850-16177-1-git-send-email-colin.king@canonical.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Mar 2016 12:48:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 384 Lines: 12 From: Colin King Date: Tue, 29 Mar 2016 18:00:50 +0100 > From: Colin Ian King > > in the case where qed_slowpath_irq_req is not called, rc is not > assigned and so qed_int_igu_enable will return a garbage value. > Fix this by initializing rc to 0. > > Signed-off-by: Colin Ian King Applied, thanks.