Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754901AbcC3Ujw (ORCPT ); Wed, 30 Mar 2016 16:39:52 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57748 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640AbcC3Ujv (ORCPT ); Wed, 30 Mar 2016 16:39:51 -0400 Date: Wed, 30 Mar 2016 13:39:46 -0700 From: Mark Brown To: Stephen Boyd Cc: Georgi Djakov , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Message-ID: <20160330203946.GT2350@sirena.org.uk> References: <1459347792-13515-1-git-send-email-georgi.djakov@linaro.org> <20160330173658.GN2350@sirena.org.uk> <20160330181709.5175.51228@sboyd-linaro> <20160330183207.GR2350@sirena.org.uk> <20160330193426.5881.34139@sboyd-linaro> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PUHnpEUN0SLOjcm5" Content-Disposition: inline In-Reply-To: <20160330193426.5881.34139@sboyd-linaro> X-Cookie: If anything can go wrong, it will. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 64.55.107.4 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: Support ramp-up delay for drivers with get_voltage() X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1256 Lines: 34 --PUHnpEUN0SLOjcm5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Mar 30, 2016 at 12:34:26PM -0700, Stephen Boyd wrote: > Ok. Just curious, why is there a 'selector' argument to the > set_voltage() op then? The qcom spmi driver is using that to allow the > list operation to return the voltage that was actually set. Is that a > 'selector' interface? We could just as easily have read the hardware to > figure out the voltage, but I think we implement the list op to avoid > reading hardware when we know what selector has been chosen during > voltage changes. Historical reasons - this predates having the split selector and map operations. --PUHnpEUN0SLOjcm5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW/DmMAAoJECTWi3JdVIfQ05YH/jpwGKt54eKCi8W2wQ+T7A/8 czJJAKgftiYcieoWity3nq4FYqbNLgbtRNlbwP5pzJu/ywieq+xYCWDiiG80HxSD Gre8C0gh8T5mLagQJ2umyL/slIXbc4clbJ37Gp2Eq112o7KEGHGEkmJP0pHjHCz+ 0L9VigQW4Hexd8DLGSY3GcpY6K/eUo4RK4Vv3AJ35inARcnrxhiAZFB0Kq0ENgi9 mbtfaFVf8OaA8WOPRUtltLL9qwTQQ0M2bol//6U0TO4whxpXmrT5Lr7JBJr28HDB 87LdHDfCMCMUf/jDlY3xyINWVP2m2MDdWE4v4/kYE8apXiRU95fuVQH/51+cbiY= =8L9E -----END PGP SIGNATURE----- --PUHnpEUN0SLOjcm5--