Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754571AbcC3VDA (ORCPT ); Wed, 30 Mar 2016 17:03:00 -0400 Received: from thoth.sbs.de ([192.35.17.2]:37179 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608AbcC3VC7 (ORCPT ); Wed, 30 Mar 2016 17:02:59 -0400 Subject: Re: [PATCHv4 01/12] scripts/gdb: Provide linux constants To: Kieran Bingham , linux-kernel@vger.kernel.org References: <1459339251-29611-1-git-send-email-kieran.bingham@linaro.org> <1459339251-29611-2-git-send-email-kieran.bingham@linaro.org> Cc: lee.jones@linaro.org, peter.griffin@linaro.org, maxime.coquelin@st.com, mmarek@suse.com, linux-kbuild@vger.kernel.org From: Jan Kiszka Message-ID: <56FC3EDA.5030701@siemens.com> Date: Wed, 30 Mar 2016 23:02:18 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1459339251-29611-2-git-send-email-kieran.bingham@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 38 On 2016-03-30 14:00, Kieran Bingham wrote: > Some macro's and defines are needed when parsing memory, and without > compiling the kernel as -g3 they are not available in the debug-symbols. > > We use the pre-processor here to extract constants to a dedicated module > for the linux debugger extensions > > Top level Kbuild is used to call in and generate the constants file, > while maintaining dependencies on autogenerated files in > include/generated > > CC: mmarek@suse.com > CC: linux-kbuild@vger.kernel.org > > Signed-off-by: Kieran Bingham > --- > Changes since v1: > > Kbuild: > - Call to generate constants_py with dependancy on generated files > > scripts/gdb/linux/Makefile: > - Use call if_changed, and correct quiet invocation > - Annouce "GEN $@" instead of GDB PP > > scripts/gdb/linux/constants.py.in: > - Updated to use better macro implementations for one line defines > --- Please only use a single separator line (i.e. remove this one), or the history blob above makes it into the commit log. But there is no need to resend if that will remain the only remark. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux