Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757AbcC3VJU (ORCPT ); Wed, 30 Mar 2016 17:09:20 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:44913 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbcC3VJS (ORCPT ); Wed, 30 Mar 2016 17:09:18 -0400 Date: Wed, 30 Mar 2016 14:09:16 -0700 From: Guenter Roeck To: Shawn Guo Cc: Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , Tim Harvey , linux-watchdog@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Justin Waters , Lucas Stach , Stefan Roese Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Message-ID: <20160330210916.GB21993@roeck-us.net> References: <20151106220249.GA19791@roeck-us.net> <565F4244.7090502@timesys.com> <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160330012226.GD28207@tiger> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 43 On Wed, Mar 30, 2016 at 09:22:33AM +0800, Shawn Guo wrote: > On Mon, Mar 28, 2016 at 04:19:15PM -0400, Akshay Bhat wrote: > > Hi Shawn, > > > > On 02/28/2016 08:56 AM, Fabio Estevam wrote: > > >Rob, > > > > > >On Thu, Jan 28, 2016 at 6:28 PM, Akshay Bhat wrote: > > > > > >>>I have no objections against the idea and the code itself. > > >>>But as Guenter pointed out: it would be handy to get feedback from the > > >>>devicetree maintainers on the above discussion. > > >>> > > >>>Kind regards, > > >>>Wim. > > >>> > > >> > > >>Any suggestions on whether a vendor specific prefix is necessary? > > > > > >Any comments? > > > > > > > Is this something you can help with, since you are the iMX > > architecture/devicetree maintainer? Appreciate any feedback. > > FWIW, > > Acked-by: Shawn Guo > > Guenter, > > I think it's reasonable to pick up the patch, if we have it copied to DT > maintainers and on the list for a long period of time, and do not see > any objection from anyone. > The question was if the property name should be ext-reset-output or fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output because it is not a generic property. Tim disagrees. So we have two options: Change the property name to fsl,ext-reset-output, which I would accept, or wait for a devicetree maintainer to make a decision. Guenter