Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754794AbcC3Vgg (ORCPT ); Wed, 30 Mar 2016 17:36:36 -0400 Received: from smtprelay0149.hostedemail.com ([216.40.44.149]:47035 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751653AbcC3Vgf (ORCPT ); Wed, 30 Mar 2016 17:36:35 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3868:3870:3871:3874:4250:4321:5007:10004:10400:10848:11232:11658:11914:12517:12519:12663:12740:13069:13255:13311:13357:13439:14181:14659:14721:21080:21326:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sign77_735c47d05f74b X-Filterd-Recvd-Size: 1390 Message-ID: <1459373791.25110.132.camel@perches.com> Subject: Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style From: Joe Perches To: Kalle Valo Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Wed, 30 Mar 2016 14:36:31 -0700 In-Reply-To: <87shz85gkq.fsf@purkki.adurom.net> References: <87shz85gkq.fsf@purkki.adurom.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 515 Lines: 12 On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > Joe Perches writes: > > Using the normal kernel logging mechanisms makes this code > > a bit more like other wireless drivers. > Personally I don't see the point but I don't have any strong opinions. A > bigger problem is that TI drivers are not really in active development > and that's I'm not thrilled to take big patches like this for dormant > drivers. Not very dormant. 35 patches in the last year, most of them adding functionality.