Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754662AbcC3V4Y (ORCPT ); Wed, 30 Mar 2016 17:56:24 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:49298 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbcC3V4W (ORCPT ); Wed, 30 Mar 2016 17:56:22 -0400 Date: Wed, 30 Mar 2016 23:56:18 +0200 From: Ralf Baechle To: Antony Pavlov Cc: Sudip Mukherjee , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: ath79: fix build failure Message-ID: <20160330215618.GB5275@linux-mips.org> References: <1459351789-24544-1-git-send-email-sudipm.mukherjee@gmail.com> <20160330221329.25ca0849d782e55c0564f139@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160330221329.25ca0849d782e55c0564f139@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 22 On Wed, Mar 30, 2016 at 10:13:29PM +0300, Antony Pavlov wrote: > It is very strange because my original patch has this closing brace. > Please see my original patch > https://www.linux-mips.org/archives/linux-mips/2016-03/msg00267.html The patch didn't apply cleanly and I botched resolving it, sorry. I folded the fix into the patch. > Also I suppose that we have no need in detect_memory_region() if we use devicetree, > e.g. > > ath79_detect_sys_type(); > ath79_ddr_ctrl_init(); > + detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); > + } > > - detect_memory_region(0, ATH79_MEM_SIZE_MIN, ATH79_MEM_SIZE_MAX); "suppose" is a bit weak.. Should I move the detect_memory_region call? Ralf