Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752883AbcCaAeh (ORCPT ); Wed, 30 Mar 2016 20:34:37 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:34023 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbcCaAeg (ORCPT ); Wed, 30 Mar 2016 20:34:36 -0400 Subject: Re: [PATCH] elevator: remove second argument in elevator_init() To: Alexey Klimov , linux-block@vger.kernel.org References: <1452822371-4967-1-git-send-email-klimov.linux@gmail.com> Cc: Linux Kernel Mailing List , Jeff Moyer , Yury Norov From: Jens Axboe Message-ID: <56FC7098.1050503@kernel.dk> Date: Wed, 30 Mar 2016 18:34:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 30 On 03/30/2016 05:31 PM, Alexey Klimov wrote: > Hi all, > > On Wed, Jan 27, 2016 at 9:01 PM, Jeff Moyer wrote: >> Alexey Klimov writes: >> >>> Last user of elevator_init() with non-NULL name as second argument >>> that supposed to be s390 dasd driver has gone few releases ago. >>> Drivers rely on elevator_change(), elevator_switch() and friends >>> for example. Right now elevator_init() is always called as >>> elevator_init(q, NULL). >>> >>> Patch removes passing of second name argument and its usage. >>> >>> While we're at it fix following if-check after removed lines. We know >>> that elevator_type e is initialized by NULL and need to check only >>> chosen_elevator. >>> >>> Signed-off-by: Alexey Klimov >> >> Reviewed-by: Jeff Moyer > > > what is the status of this patch? Is it that wrong and are there some > concerns or do I need to resend it? It looks fine, I'll pick it up for 4.7. -- Jens Axboe