Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233AbcCaBLe (ORCPT ); Wed, 30 Mar 2016 21:11:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43376 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbcCaBLd (ORCPT ); Wed, 30 Mar 2016 21:11:33 -0400 Subject: Re: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message To: "Moore, Robert" , "Zheng, Lv" , "Wysocki, Rafael J" , Len Brown References: <74bc15316c48bb33c0954d94c0595720ee0955bd.1459187689.git.bristot@redhat.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37E455538@ORSMSX110.amr.corp.intel.com> Cc: "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "linux-kernel@vger.kernel.org" From: Daniel Bristot de Oliveira Message-ID: <56FC7941.2080202@redhat.com> Date: Wed, 30 Mar 2016 22:11:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <94F2FBAB4432B54E8AACC7DFDE6C92E37E455538@ORSMSX110.amr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 15 On 03/29/2016 04:09 PM, Moore, Robert wrote: > Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem? Well, I do not believe that there is a real problem on it. On the other hand, it does not seem to be common to have blank lines in the kernel log, and as there is no info about from where the black line comes from, it does not even seems to be connected to the previous message. So although my patch is about "cosmetics", IMHO it is worth as pattern or best practices. Feel free to reject if it is not the case, np :-). -- Daniel