Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755389AbcCaB56 (ORCPT ); Wed, 30 Mar 2016 21:57:58 -0400 Received: from mail.kernel.org ([198.145.29.136]:39852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755029AbcCaB5y (ORCPT ); Wed, 30 Mar 2016 21:57:54 -0400 Date: Thu, 31 Mar 2016 09:57:14 +0800 From: Shawn Guo To: Guenter Roeck , Tim Harvey Cc: Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Justin Waters , Lucas Stach , Stefan Roese Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Message-ID: <20160331015714.GM28207@tiger> References: <20151106220249.GA19791@roeck-us.net> <565F4244.7090502@timesys.com> <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> <20160330210916.GB21993@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160330210916.GB21993@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 19 On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote: > The question was if the property name should be ext-reset-output or > fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output > because it is not a generic property. Tim disagrees. > > So we have two options: Change the property name to fsl,ext-reset-output, > which I would accept, or wait for a devicetree maintainer to make a decision. Guenter, I agree with you on this point. Before everyone agrees that this is a generic binding, we should have vendor prefix for the property. Tim, This is a small change which, IMO, shouldn't hold an useful patch from being merged. Care to resend with the suggested change? Shawn