Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755473AbcCaCmi (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Mar 2016 22:42:38 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:10138 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750704AbcCaCmh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Mar 2016 22:42:37 -0400
Message-ID: <1459392151.29450.44.camel@mtksdaap41>
Subject: Re: [PATCH] sbs-battery: fix power status when battery is dry
From: YH Huang <yh.huang@mediatek.com>
To: Sebastian Reichel <sre@kernel.org>
CC: Rhyland Klein <rklein@nvidia.com>, Daniel Kurtz <djkurtz@chromium.org>,
        <linux-pm@vger.kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Date: Thu, 31 Mar 2016 10:42:31 +0800
In-Reply-To: <20160330150919.GA21068@earth>
References: <1458726794-48298-1-git-send-email-yh.huang@mediatek.com>
	 <CAGS+omDTmJDkJYsf=gDJMrmAos+30enoAa2xfTPyirXUd37=9g@mail.gmail.com>
	 <1458801832.16645.7.camel@mtksdaap41>
	 <CAGS+omDhFP+_shCqEWasLDsHf-ab0-OWJJ-gZZkgihAgrZwBHA@mail.gmail.com>
	 <1459132330.16645.14.camel@mtksdaap41>
	 <CAGS+omBVStB3mfXtDHdbsOK+y2UesGYtZBtYm=ctcpBfm88VEg@mail.gmail.com>
	 <56F95451.5040607@nvidia.com> <1459216353.16645.20.camel@mtksdaap41>
	 <56FA99D0.1010004@nvidia.com> <1459328310.29450.24.camel@mtksdaap41>
	 <20160330150919.GA21068@earth>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2705
Lines: 68

On Wed, 2016-03-30 at 17:09 +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Mar 30, 2016 at 04:58:30PM +0800, YH Huang wrote:
> > If I revise the description in this way(using your clear explanation):
> > ------------------------------------------------------------------------
> > The battery capacity changing course is like this:
> > 
> > full: BATTERY_FULLY_CHARGED => POWER_SUPPLY_STATUS_FULL
> > <unplug AC>
> > high->low: BATTERY_DISCHARGING => POWER_SUPPLY_STATUS_DISCHARGING
> > ~0%: DISCHARGING & FULLY_DISCHARGED => POWER_SUPPLY_STATUS_NOT_CHARGING
> > <plug in AC>
> > 0%~20%: FULLY_DISCHARGED => POWER_SUPPLY_STATUS_CHARGING
> > 20%~: No flag => POWER_SUPPLY_STATUS_CHARGING
> > 
> > For now, it is not exactly right to show the status as
> > POWER_SUPPLY_STATUS_NOT_CHARGING when the battery is dry
> > (FULLY_DISCHARGED) and AC is plugged in.
> > Although the battery is in a low level, system works fine with the AC
> > charging.
> > It is better to say that the battery is charging.
> > ------------------------------------------------------------------------
> > 
> > How about this?
> > By the way, should I also revise the title?
> 
> POWER_SUPPLY_STATUS_NOT_CHARGING is used for AC connected, but
> battery not charging (e.g. because battery temperature is out
> of acceptable range). If you are discharging use
> POWER_SUPPLY_STATUS_DISCHARGING.
> 
> You should just ignore the FULLY_DISCHARGED bit in the status
> property. If you don't want to loose the information about fully
> discharged battery add POWER_SUPPLY_PROP_CAPACITY_LEVEL, which maps:
> 
> BATTERY_FULLY_CHARGED => POWER_SUPPLY_CAPACITY_LEVEL_FULL
> FULLY_DISCHARGED => POWER_SUPPLY_CAPACITY_LEVEL_CRITICAL
> otherwise => POWER_SUPPLY_CAPACITY_LEVEL_NORMAL

Oops.
It looks like I misunderstand POWER_SUPPLY_STATUS_NOT_CHARGING.
As Daniel said before, we could just ignore FULLY_DISCHARGED.

So change like the

sbs-battery: fix power status when battery charging near
dry

POWER_SUPPLY_STATUS_NOT_CHARGING is used for AC connected, but
battery not charging (e.g. because battery temperature is out
of acceptable range).

When battery is charging near dry and BATTERY_FULL_DISCHARGED is set,
it is wrong to set as POWER_SUPPLY_STATUS_NOT_CHARGING.
Just use BATTERY_DISCHARGING to decide the power supply status is
discharging or charging.

                if (ret & BATTERY_FULL_CHARGED)
                        val->intval = POWER_SUPPLY_STATUS_FULL;
-               else if (ret & BATTERY_FULL_DISCHARGED)
-                       val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
                else if (ret & BATTERY_DISCHARGING)
                        val->intval = POWER_SUPPLY_STATUS_DISCHARGING;


YH Huang