Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbcCaE1P (ORCPT ); Thu, 31 Mar 2016 00:27:15 -0400 Received: from smtprelay0077.hostedemail.com ([216.40.44.77]:40524 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751225AbcCaE1O (ORCPT ); Thu, 31 Mar 2016 00:27:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:4321:5007:7903:9108:10004:10400:10848:11232:11658:11914:12048:12517:12519:12679:12740:13069:13095:13311:13357:13439:14659:21080:21212:30054:30064:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: knot69_3e990a672a816 X-Filterd-Recvd-Size: 1868 Message-ID: <1459398427.1744.2.camel@perches.com> Subject: Re: [PATCH] ACPICA: Remove unnecessary "\n" from an ACPI_INFO boot message From: Joe Perches To: Daniel Bristot de Oliveira , "Moore, Robert" , "Zheng, Lv" , "Wysocki, Rafael J" , Len Brown Cc: "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "linux-kernel@vger.kernel.org" Date: Wed, 30 Mar 2016 21:27:07 -0700 In-Reply-To: <56FC7941.2080202@redhat.com> References: <74bc15316c48bb33c0954d94c0595720ee0955bd.1459187689.git.bristot@redhat.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37E455538@ORSMSX110.amr.corp.intel.com> <56FC7941.2080202@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 12 On Wed, 2016-03-30 at 22:11 -0300, Daniel Bristot de Oliveira wrote: > On 03/29/2016 04:09 PM, Moore, Robert wrote: > > Actually, I did in fact put that there to break up the output after the tables are loaded. Is this a problem? > Well, I do not believe that there is a real problem on it. > > On the other hand, it does not seem to be common to have blank lines in > the kernel log, and as there is no info about from where the black line > comes from, it does not even seems to be connected to the previous > message. So although my patch is about "cosmetics", IMHO it is worth as > pattern or best practices. FWIW: I agree with Daniel.