Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbcCaFJM (ORCPT ); Thu, 31 Mar 2016 01:09:12 -0400 Received: from hotel311.server4you.de ([85.25.146.15]:34678 "EHLO hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbcCaFJK (ORCPT ); Thu, 31 Mar 2016 01:09:10 -0400 Subject: Re: [PATCH v16 22/23] tracing: Add hist trigger 'log2' modifier To: Namhyung Kim References: <7ff396b246c6a881f46b979735fddf05a0d6c71a.1457029949.git.tom.zanussi@linux.intel.com> <56FA5284.2050106@monom.org> <20160329151701.GA1797@danjae> Cc: Tom Zanussi , rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com, josh@joshtriplett.org, andi@firstfloor.org, mathieu.desnoyers@efficios.com, peterz@infradead.org, linux-kernel@vger.kernel.org From: Daniel Wagner Message-ID: <56FCB0F3.4060908@monom.org> Date: Thu, 31 Mar 2016 07:09:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160329151701.GA1797@danjae> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 619 Lines: 21 Hi Namhyung, On 03/29/2016 05:17 PM, Namhyung Kim wrote: > On Tue, Mar 29, 2016 at 12:01:40PM +0200, Daniel Wagner wrote: >> cat /sys/kernel/debug/tracing/events/test/latency_complete/hist >> # event histogram >> # >> # trigger info: hist:keys=latency.log2:vals=hitcount:sort=latency.log2:size=2048 [active] >> # >> # > > Maybe we want to skip printing those flags for sort keys.. > What about this? Yes, something like this makes sense to me. As I said, it is only a minor detail and maybe just not worth the extra code. Anyway, the hist patches do really work nicely. I hope they get merged soon. cheers, daniel