Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474AbcCaHfR (ORCPT ); Thu, 31 Mar 2016 03:35:17 -0400 Received: from lucky1.263xmail.com ([211.157.147.131]:35080 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbcCaHfP (ORCPT ); Thu, 31 Mar 2016 03:35:15 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: jh80.chung@samsung.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <4ccd87159a832f8e7e450eabbc42eb94> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Shawn Lin To: Jaehoon Chung , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org, Shawn Lin Subject: [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Date: Thu, 31 Mar 2016 15:33:36 +0800 Message-Id: <1459409616-20306-1-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 1.8.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1120 Lines: 34 Hello Jeahoon Currently dw_mmc is a little too queen-size. As we had cleanup prepare_command callback some days before, there are also some ones deserve to remove. Also we should avoid add new quirks or callbacks into dw_mmc in order to avoid the dilemma sdhci meets now. This patchset remove setup_clock callback. Obviously, add a callback just for one-time-used clk stuff make no sense. We combine what setup_clock does before into init callback. For exynos platfrom, it needs call init hook after resume, so we add new argument in init hook to indicate whether it needs do clk stuff or not. Changes in v2: - rebase on linux-mmc next - remove add setup_clk flag for init callback Shawn Lin (3): mmc: dw_mmc-rockchip: remove setup_clock for rockchip mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock mmc: dw_mmc: remove setup_clock callback drivers/mmc/host/dw_mmc-exynos.c | 8 -------- drivers/mmc/host/dw_mmc-rockchip.c | 12 ++++-------- drivers/mmc/host/dw_mmc.c | 9 --------- drivers/mmc/host/dw_mmc.h | 2 -- 4 files changed, 4 insertions(+), 27 deletions(-) -- 2.3.7