Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755727AbcCaIKn (ORCPT ); Thu, 31 Mar 2016 04:10:43 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33216 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133AbcCaIKd (ORCPT ); Thu, 31 Mar 2016 04:10:33 -0400 MIME-Version: 1.0 In-Reply-To: <1458806625-29300-1-git-send-email-yegorslists@googlemail.com> References: <1458806625-29300-1-git-send-email-yegorslists@googlemail.com> From: "Matwey V. Kornilov" Date: Thu, 31 Mar 2016 11:10:12 +0300 X-Google-Sender-Auth: heF_GRpsML4jFdV6MYmSt-2KqcM Message-ID: Subject: Re: [PATCH v2] tty/serial/8250: fix RS485 half-duplex RX To: Yegor Yefremov Cc: linux-serial@vger.kernel.org, Greg KH , Peter Hurley , bigeasy@linutronix.de, linux-kernel , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1878 Lines: 55 2016-03-24 11:03 GMT+03:00 : > From: Yegor Yefremov > > When in half-duplex mode RX will be disabled before TX, but not > enabled after deactivating transmitter. This patch enables > UART_IER_RLSI and UART_IER_RDI interrupts after TX is over. > > Cc: Matwey V. Kornilov > Signed-off-by: Yegor Yefremov > Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250") Acked-by: Matwey V. Kornilov > --- > Changes: > v2: change subject and add 'Fixes' tag > > drivers/tty/serial/8250/8250_port.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c > index e213da0..00ad263 100644 > --- a/drivers/tty/serial/8250/8250_port.c > +++ b/drivers/tty/serial/8250/8250_port.c > @@ -1403,9 +1403,18 @@ static void __do_stop_tx_rs485(struct uart_8250_port *p) > /* > * Empty the RX FIFO, we are not interested in anything > * received during the half-duplex transmission. > + * Enable previously disabled RX interrupts. > */ > - if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX)) > + if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX)) { > serial8250_clear_fifos(p); > + > + serial8250_rpm_get(p); > + > + p->ier |= UART_IER_RLSI | UART_IER_RDI; > + serial_port_out(&p->port, UART_IER, p->ier); > + > + serial8250_rpm_put(p); > + } > } > > static void serial8250_em485_handle_stop_tx(unsigned long arg) > -- > 2.1.4 > -- With best regards, Matwey V. Kornilov. Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia 119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382