Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755251AbcCaITi (ORCPT ); Thu, 31 Mar 2016 04:19:38 -0400 Received: from mail.kernel.org ([198.145.29.136]:55347 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755045AbcCaITe (ORCPT ); Thu, 31 Mar 2016 04:19:34 -0400 Date: Thu, 31 Mar 2016 16:19:08 +0800 From: Shawn Guo To: Stefan Agner Cc: mturquette@baylibre.com, sboyd@codeaurora.org, kernel@pengutronix.de, sergeimir@emcraft.com, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 03/18] ARM: dts: vf610-colibri: GPIO wakeup key Message-ID: <20160331081908.GV28207@tiger> References: <1457576219-7971-1-git-send-email-stefan@agner.ch> <1457576219-7971-4-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457576219-7971-4-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 71 On Wed, Mar 09, 2016 at 06:16:44PM -0800, Stefan Agner wrote: > Enable GPIO wakeup key on Vybrid PAD 41 which is routed to the > Colibri default wakeup pin SO-DIMM 45. > > Signed-off-by: Stefan Agner I think this one can be merged independently, right? One small comment below though. > --- > arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi > index 4d8b7f6..936ece6 100644 > --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi > +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi > @@ -39,6 +39,8 @@ > * OTHER DEALINGS IN THE SOFTWARE. > */ > > +#include > + > / { > chosen { > stdout-path = "serial0:115200n8"; > @@ -74,6 +76,20 @@ > gpio = <&gpio2 19 GPIO_ACTIVE_LOW>; /* USBH_PEN resp. USBH_P_EN */ > vin-supply = <®_5v0>; > }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_gpiokeys>; > + > + power { > + label = "Wake-Up"; > + gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; > + linux,code = ; > + debounce-interval = <10>; > + gpio-key,wakeup; Please use generic 'wakeup-source' instead. See the following document for details. Documentation/devicetree/bindings/power/wakeup-source.txt Shawn > + }; > + }; > }; > > &bl { > @@ -157,5 +173,11 @@ > VF610_PAD_PTB21__GPIO_43 0x22ed > >; > }; > + > + pinctrl_gpiokeys: gpiokeys { > + fsl,pins = < > + VF610_PAD_PTB19__GPIO_41 0x218d > + >; > + }; > }; > }; > -- > 2.7.2 > >