Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754353AbcCaIbI (ORCPT ); Thu, 31 Mar 2016 04:31:08 -0400 Received: from mail-ig0-f196.google.com ([209.85.213.196]:35447 "EHLO mail-ig0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035AbcCaIbG (ORCPT ); Thu, 31 Mar 2016 04:31:06 -0400 MIME-Version: 1.0 In-Reply-To: <1459348115-6072-1-git-send-email-ww.tao0320@gmail.com> References: <1459348115-6072-1-git-send-email-ww.tao0320@gmail.com> Date: Thu, 31 Mar 2016 16:31:04 +0800 Message-ID: Subject: Re: [PATCH 1/2] lightnvm: use rrpc->nr_luns to calculate the rrpc area size From: Wenwei Tao To: Matias Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 30 2016-03-30 22:28 GMT+08:00 Wenwei Tao : > rrpc->nr_sects is calculated after rrpc init luns succeeds, > before that the value of rrpc->nr_sects is zero, so we cannot > use it to calcuate rrpc area size, we use rrpc->nr_luns instead. > > Signed-off-by: Wenwei Tao > --- > drivers/lightnvm/rrpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c > index 3ab6495..516a045 100644 > --- a/drivers/lightnvm/rrpc.c > +++ b/drivers/lightnvm/rrpc.c > @@ -1223,7 +1223,7 @@ static int rrpc_area_init(struct rrpc *rrpc, sector_t *begin) > { > struct nvm_dev *dev = rrpc->dev; > struct nvmm_type *mt = dev->mt; > - sector_t size = rrpc->nr_sects * dev->sec_size; > + sector_t size = dev->sec_size * dev->sec_per_lun * rrpc->nr_luns; dev->sec_size * dev->sec_per_lun * rrpc->nr_luns could be oveflow, should use (sector_t)dev->sec_size * dev->sec_per_lun * rrpc->nr_luns instead. Will submit another patch to fix it. > > size >>= 9; > > -- > 2.7.2.333.g70bd996 >