Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbcCaJUi (ORCPT ); Thu, 31 Mar 2016 05:20:38 -0400 Received: from casper.infradead.org ([85.118.1.10]:43180 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018AbcCaJUe (ORCPT ); Thu, 31 Mar 2016 05:20:34 -0400 Date: Thu, 31 Mar 2016 11:20:31 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: Frederic Weisbecker , Linus Torvalds , LKML , Thomas Gleixner , Andrew Morton Subject: Re: [PATCH 0/3] nohz: Convert tick dependency mask to atomic_t Message-ID: <20160331092031.GH3408@twins.programming.kicks-ass.net> References: <1458830281-4255-1-git-send-email-fweisbec@gmail.com> <20160325084847.GA15235@gmail.com> <20160325131732.GA16488@lerouge> <20160329094454.GA4715@gmail.com> <20160329125950.GA2768@gmail.com> <20160329130514.GA17315@gmail.com> <20160329130808.GB7696@lerouge> <20160331065419.GA19297@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160331065419.GA19297@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 591 Lines: 12 On Thu, Mar 31, 2016 at 08:54:19AM +0200, Ingo Molnar wrote: > Sounds good to me! I also volunteer the x86 architecture to be the guinea pig to > convert thread_info::flags to atomic_t ;-) [*] So I'm not sure we can do this one arch at a time; all the TIF manipulators live in include/linux/thread_info.h and are shared across all archs. Another thing to look out for is that set_bit() uses LOCK BTS when the bit is not a compile time constant, we do not have an atomic_*() version of that. Now I'm not sure if this matters, we might never end up triggering that code path for TIF flags.