Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755832AbcCaKBs (ORCPT ); Thu, 31 Mar 2016 06:01:48 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34102 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbcCaKBr (ORCPT ); Thu, 31 Mar 2016 06:01:47 -0400 MIME-Version: 1.0 In-Reply-To: <1459093489-18314-2-git-send-email-paul.gortmaker@windriver.com> References: <1459093489-18314-1-git-send-email-paul.gortmaker@windriver.com> <1459093489-18314-2-git-send-email-paul.gortmaker@windriver.com> Date: Thu, 31 Mar 2016 12:01:46 +0200 Message-ID: Subject: Re: [PATCH 1/9] drivers/gpio: make gpio-bcm-kona.c explicitly non-modular From: Linus Walleij To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Ray Jui , Alexandre Courbot , bcm-kernel-feedback-list , "linux-gpio@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 33 On Sun, Mar 27, 2016 at 5:44 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config GPIO_BCM_KONA > bool "Broadcom Kona GPIO" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modularity so that when reading the > driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Ray Jui > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied. Yours, Linus Walleij