Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755521AbcCaK45 (ORCPT ); Thu, 31 Mar 2016 06:56:57 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37660 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752240AbcCaK44 convert rfc822-to-8bit (ORCPT ); Thu, 31 Mar 2016 06:56:56 -0400 MIME-Version: 1.0 In-Reply-To: <56FCF67A.8090109@samsung.com> References: <1458758847-21170-1-git-send-email-gustavo@padovan.org> <56F3A2DC.8080507@samsung.com> <56F47D01.7040508@samsung.com> <56F88828.5050304@samsung.com> <56F9E613.1030902@samsung.com> <56FCD5A3.4040700@samsung.com> <56FCF67A.8090109@samsung.com> Date: Thu, 31 Mar 2016 11:56:54 +0100 Message-ID: Subject: Re: [RFC 0/6] drm/fences: add in-fences to DRM From: Daniel Stone To: Inki Dae Cc: Rob Clark , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Daniel Vetter , Riley Andrews , Gustavo Padovan , John Harrison Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 23 Hi Inki, On 31 March 2016 at 11:05, Inki Dae wrote: > 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: >> On 31 March 2016 at 08:45, Inki Dae wrote: >>> As of now, it seems that this wouldn't be optional but mandatory if explicit fence support is added to the atomic helper framework. This would definitely be duplication and it seems not clear enough even if one of them is just skipped in runtime. >> >> Drivers would have to opt in to explicit fencing support, and part of >> that would be ensuring that the driver does not wait on implicit >> fences when the user has requested explicit fencing be used. >> > > Then, existing drivers would need additional works for explicit fencing support. This wouldn't be really what the drivers have to but should be handled with this patch series because this would affect exising device drivers which use implicit fencing. Well, yes. Anyone implementing their own atomic commit would need to ensure that the commit works properly for fences. The helpers could also add it, but the helpers are not mandatory, and you are not required to use every part of the helper to use one part of the helper. There is no magic wand you can wave that instantly makes it work for every driver. Cheers, Daniel