Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756060AbcCaLu2 (ORCPT ); Thu, 31 Mar 2016 07:50:28 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35054 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbcCaLu0 (ORCPT ); Thu, 31 Mar 2016 07:50:26 -0400 MIME-Version: 1.0 In-Reply-To: <20160331091426.GE11035@twins.programming.kicks-ass.net> References: <1458858367-2831-1-git-send-email-smuckle@linaro.org> <20160331075951.GG3408@twins.programming.kicks-ass.net> <20160331091426.GE11035@twins.programming.kicks-ass.net> Date: Thu, 31 Mar 2016 13:50:24 +0200 X-Google-Sender-Auth: SM4OlqxV6fUJXBX91p01Xwb_3R4 Message-ID: Subject: Re: [RFC PATCH] sched/fair: call cpufreq hook in additional paths From: "Rafael J. Wysocki" To: Peter Zijlstra Cc: Steve Muckle , Ingo Molnar , "Rafael J. Wysocki" , Linux Kernel Mailing List , "linux-pm@vger.kernel.org" , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette , Byungchul Park Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 22 On Thu, Mar 31, 2016 at 11:14 AM, Peter Zijlstra wrote: > On Thu, Mar 31, 2016 at 09:59:51AM +0200, Peter Zijlstra wrote: >> > - passing an argument into attach_entity_load_avg() to indicate >> > whether calling the cpufreq hook is necessary >> > >> > Both of these are ugly in their own way but would avoid a runtime >> > cost. Opinions welcome. >> >> Lemme see what this would look like while I throw the below into the bit >> bucket. > > OK, so the below looks a lot more sane; Yup. > and has the surprising benefit of actually shrinking the text size.. > > 43675 1226 24 44925 af7d defconfig-build/kernel/sched/fair.o.base > 43723 1226 24 44973 afad defconfig-build/kernel/sched/fair.o.patch > 43595 1226 24 44845 af2d defconfig-build/kernel/sched/fair.o.patch+ Interesting. :-)